test: fix tests

penpot · Oct 8, 2024 · b436c4a · b436c4a
1 parent 7de4379
commit b436c4a
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/libs/plugins-runtime/src/lib/assets/resize.svg b/libs/plugins-runtime/src/lib/assets/resize.svg
diff --git a/libs/plugins-runtime/src/lib/create-modal.spec.ts b/libs/plugins-runtime/src/lib/create-modal.spec.ts
@@ -44,10 +44,6 @@ describe('createModal', () => {
       '--modal-block-start',
       '40px'
     );
-    expect(modal.style.setProperty).toHaveBeenCalledWith(
-      '--modal-inline-end',
-      '320px'
-    );
 
     expect(modal.setAttribute).toHaveBeenCalledWith('title', 'Test Modal');
     expect(modal.setAttribute).toHaveBeenCalledWith(
@@ -83,7 +79,7 @@ describe('createModal', () => {
       options
     );
 
-    const expectedWidth = 680; // 1000 - 320 (initialPosition.inlineEnd)
+    const expectedWidth = 730; // 1000 -  270 (initialPosition.inlineEnd)
     const expectedHeight = 760; // 800 - 40 (initialPosition.blockStart)
 
     expect(modal.setAttribute).toHaveBeenCalledWith(

diff --git a/libs/plugins-runtime/src/lib/create-modal.ts b/libs/plugins-runtime/src/lib/create-modal.ts
@@ -18,11 +18,16 @@ export function createModal(
   const defaultWidth = 335;
   const defaultHeight = 590;
 
+  const maxWidth =
+    (options?.width ?? defaultWidth) > window.innerWidth
+      ? window.innerWidth - 270
+      : options?.width ?? defaultWidth;
+
   const initialPosition = {
     blockStart: 40,
     // To be able to resize the element as expected the position must be absolute from the right.
     // This value is the length of the window minus the width of the element plus the width of the design tab.
-    inlineStart: window.innerWidth - defaultWidth - 270,
+    inlineStart: window.innerWidth - maxWidth - 270,
   };
 
   modal.style.setProperty(
@@ -34,7 +39,6 @@ export function createModal(
     `${initialPosition.inlineStart}px`
   );
 
-  const maxWidth = window.innerWidth - initialPosition.inlineStart;
   const maxHeight = window.innerHeight - initialPosition.blockStart;
   let width = Math.min(options?.width || defaultWidth, maxWidth);
   let height = Math.min(options?.height || defaultHeight, maxHeight);

diff --git a/libs/plugins-runtime/src/lib/modal/plugin.modal.css b/libs/plugins-runtime/src/lib/modal/plugin.modal.css
@@ -26,7 +26,7 @@
 }
 
 ::-webkit-resizer {
-  display: none;/
+  display: none;
 }
 
 .wrapper {