-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Club approval response templates #739
Conversation
380eac7
to
c9f36cb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #739 +/- ##
==========================================
+ Coverage 71.68% 71.80% +0.11%
==========================================
Files 31 31
Lines 6870 6901 +31
==========================================
+ Hits 4925 4955 +30
- Misses 1945 1946 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is sick, great work Rohan. Backend code LGTM. About the frontend: do we plan to support someone applying multiple templates to the same approval decision? I can envision a club getting rejected for multiple reasons (e.g. a club's name has Penn in it, and it doesn't have enough members).
Just added this, if one of you can test locally and let me know if it works that would be great 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, some code duplication is acceptable given the scale so LGTM!
ebe0bc9
to
3f606f3
Compare
This PR introduces a new feature that enables site administrators to efficiently manage templated responses for the club approval/rejection process. Admins can now create, update, and select predefined templates when approving or rejecting clubs (works for individual or bulk approvals/rejections). This feature replaces the manual task of copying and pasting responses, reducing overhead and ensuring consistent messaging
Template management tab on admin dashboard:
Template dropdown on club page:
Template dropdown on queue page for bulk approvals/rejections: