-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for elapsed events in ticketing #734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #734 +/- ##
==========================================
+ Coverage 71.68% 71.71% +0.02%
==========================================
Files 31 31
Lines 6859 6865 +6
==========================================
+ Hits 4917 4923 +6
Misses 1942 1942 ☔ View full report in Codecov by Sentry. |
aviupadhyayula
changed the title
Check that tickets are not for elapsed events in cart endpoint
Add checks for elapsed events in ticketing
Oct 10, 2024
rm03
pushed a commit
that referenced
this pull request
Oct 15, 2024
* Add check on event end time in cart endpoint * Add tests * Tweak frontend toast * Reinsert comment * style * Remove extra query * Add check to add_to_cart * Add test to add_to_cart * Minor fix * Minor fix * Disable "Get Tickets" button for elapsed events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds various frontend and backend tweaks to behavior in the case where an event has elapsed.