Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks for elapsed events in ticketing #734

Merged
merged 11 commits into from
Oct 14, 2024

Conversation

aviupadhyayula
Copy link
Member

@aviupadhyayula aviupadhyayula commented Oct 10, 2024

Adds various frontend and backend tweaks to behavior in the case where an event has elapsed.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.71%. Comparing base (0275dcb) to head (72af455).
Report is 14 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #734      +/-   ##
==========================================
+ Coverage   71.68%   71.71%   +0.02%     
==========================================
  Files          31       31              
  Lines        6859     6865       +6     
==========================================
+ Hits         4917     4923       +6     
  Misses       1942     1942              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviupadhyayula aviupadhyayula changed the title Check that tickets are not for elapsed events in cart endpoint Add checks for elapsed events in ticketing Oct 10, 2024
@aviupadhyayula aviupadhyayula merged commit 6295feb into master Oct 14, 2024
8 checks passed
@aviupadhyayula aviupadhyayula deleted the expire-elapsed-tickets branch October 14, 2024 01:24
rm03 pushed a commit that referenced this pull request Oct 15, 2024
* Add check on event end time in cart endpoint

* Add tests

* Tweak frontend toast

* Reinsert comment

* style

* Remove extra query

* Add check to add_to_cart

* Add test to add_to_cart

* Minor fix

* Minor fix

* Disable "Get Tickets" button for elapsed events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant