Change club serialization based on approval status #733
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #733 +/- ##
==========================================
+ Coverage 71.67% 71.69% +0.02%
==========================================
Files 31 31
Lines 6855 6860 +5
==========================================
+ Hits 4913 4918 +5
Misses 1942 1942 ☔ View full report in Codecov by Sentry. |
| self.user.user_permissions.add( | ||
| Permission.objects.get(codename="see_pending_clubs") | ||
| ) | ||
| request = self.factory.get(reverse("clubs-detail", args=[self.club.code])) |
There was a problem hiding this comment.
Is there a reason for not using client like in the other test files?
There was a problem hiding this comment.
We don't want to actually send the request to the API -- we just want to create the request object, and then pass it to the serializer. This lets us test the serializer itself instead of the entire view.
The user_permissions.add pattern was unintentional. Changed to self.user.is_superuser = True instead.
|
|
||
| def test_non_privileged_user_during_renewal_period(self): | ||
| # Simulate deactivation at the beginning of the renewal period | ||
| self.club.save() |
| self.club.name = "Current Cycle Approved Version" | ||
| self.club.approved = True | ||
| self.club.approved_on = approved_date | ||
| self.club.save() |
There was a problem hiding this comment.
Unless there is internal logic in club.save or serializer.to_representation that uses django.utils.timezone.now, we might not need the with clauses since we are explicitly setting club.approved_on
| Return the previous approved version of a club for users | ||
| that should not see unapproved content. | ||
| Return appropriate version of club based on user permissions and club status: | ||
| - Privileged users see current version (or when bypass=True) |
There was a problem hiding this comment.
What's the use case for bypass=True? I don't think clubs should be allowed to show an unapproved version at all
aviupadhyayula
changed the title
Re-hauls serialization to show clubs differently based on their approval status and the current time (whether we're in a renewal period or not). Adds tests to serialization logic and aligns view-related unit tests to this change.
This lets us deprecate the
ghostattribute and should simplify the display flow. See this Slack thread for more info.