Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Club.get_officer_emails() to send alerts #729

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

aviupadhyayula
Copy link
Member

Replaces duplicated logic across notification flows.

Copy link

sentry-io bot commented Sep 26, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: backend/clubs/models.py

Function Unhandled Issue
__str__ AttributeError: 'NoneType' object has no attribute 'name' /api/admin/clubs/applicationsu...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.39%. Comparing base (fbedec8) to head (9fb6eb8).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
backend/clubs/models.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #729      +/-   ##
==========================================
- Coverage   71.40%   71.39%   -0.02%     
==========================================
  Files          31       31              
  Lines        6850     6851       +1     
==========================================
  Hits         4891     4891              
- Misses       1959     1960       +1     
Flag Coverage Δ
71.39% <40.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aviupadhyayula aviupadhyayula merged commit 308fc0b into master Sep 27, 2024
7 of 9 checks passed
@aviupadhyayula aviupadhyayula deleted the avi/exclude-inactives-from-emails branch September 27, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants