Fix permission-related display issues after club deactivation #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #715 +/- ##
==========================================
+ Coverage 71.29% 71.40% +0.10%
==========================================
Files 31 31
Lines 6842 6850 +8
==========================================
+ Hits 4878 4891 +13
+ Misses 1964 1959 -5 ☔ View full report in Codecov by Sentry. |
aviupadhyayula
commented
Sep 1, 2024
| @@ -11,7 +11,7 @@ | |||
| TEST_OUTPUT_DIR = "test-results" | |||
|
|
|||
| # Use dummy cache for testing | |||
| CACHES = {"default": {"BACKEND": "django.core.cache.backends.dummy.DummyCache"}} | |||
| CACHES = {"default": {"BACKEND": "django.core.cache.backends.locmem.LocMemCache"}} | |||
There was a problem hiding this comment.
Caching was effectively turned off in CI/CD tests -- not sure what the original intention was, but I'm reverting it back. We interact with the cache manually in a lot of our views, so feels reasonable that the unit tests also check its correctness.
aviupadhyayula
changed the title
aviupadhyayula
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deactivated clubs are displayed differently to permissioned vs non-permissioned users. Users without permissions are expected to see the last approved version; users with permissions see the most up-to-date version. Currently, caching in the viewset incorrect caches the non-permissioned state and displays it to permissioned users. This leads to approval messages showing up in the club management dashboard, despite the club not being approved.
This PR adds a test to check this case (should fail with current code), and adds a fix. It also turns on caching in CI.