Configure hardware clock and hardware based timestamping automatically when available by default #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y when available by default
davidv1992
reviewed
Oct 16, 2024
Comment on lines
+313
to
+345
| macro_rules! add_hw { | ||
| ($idx:expr) => {{ | ||
| let idx = $idx; | ||
| let mut clock = LinuxClock::open_idx(idx).expect("Unable to open clock"); | ||
| if let Some(id) = clock_name_map.get(&idx) { | ||
| clock_port_map.push(Some(*id)); | ||
| } else { | ||
| clock.init().expect("Unable to initialize clock"); | ||
| let id = internal_sync_senders.len(); | ||
| clock_port_map.push(Some(id)); | ||
| clock_name_map.insert(idx, id); | ||
| internal_sync_senders | ||
| .push(start_clock_task(clock.clone(), system_clock.clone())); | ||
| } | ||
| ( | ||
| Some(idx), | ||
| Box::new(clock) as BoxedClock, | ||
| InterfaceTimestampMode::HardwarePTPAll, | ||
| ) | ||
| }}; | ||
| } | ||
|
|
||
| macro_rules! add_sw { | ||
| () => {{ | ||
| clock_port_map.push(None); | ||
| ( | ||
| None, | ||
| system_clock.clone_boxed(), | ||
| InterfaceTimestampMode::SoftwareAll, | ||
| ) | ||
| }}; | ||
| } | ||
|
|
There was a problem hiding this comment.
I am a bit uncomfortable with these being macros. What is stopping us from making these just outright functions (and exposing all the dependencies on names in the surrounding code)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this requires a new release of timestamped-socket first.