Added configurable minor version number. #546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 62.20% 62.46% +0.26%
==========================================
Files 63 63
Lines 8225 8288 +63
==========================================
+ Hits 5116 5177 +61
- Misses 3109 3111 +2 ☔ View full report in Codecov by Sentry. |
rnijveld
reviewed
Oct 8, 2024
| // Notes: | ||
| // Fields specific for delay mechanism are kept as part of [DelayMechanism]. | ||
| // Version is always 2.1, so not stored (versionNumber, minorVersionNumber) | ||
| // Major version is always 2.1, so not stored (versionNumber) |
There was a problem hiding this comment.
Suggested change
| // Major version is always 2.1, so not stored (versionNumber) | |
| // Major version is always 2, so not stored (versionNumber) |
rnijveld
reviewed
Oct 8, 2024
| @@ -64,6 +64,8 @@ pub struct PortConfig { | |||
| pub delay_mechanism: DelayType, | |||
| #[serde(default = "default_delay_interval")] | |||
| pub delay_interval: i8, | |||
| #[serde(default = "default_minor_ptp_version")] | |||
| pub minor_ptp_version: u8, | |||
There was a problem hiding this comment.
I guess this technically right now allows you to specify version 2.255, which feels like something we really shouldn't allow. Maybe use an enum MinorVersion { Zero, One } with a From<MinorVersion> for u8, TryFrom<u8> for MinorVersion and equivalent serde implementations?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.