-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reworked bmca running to use new interface. #176
Conversation
Codecov Report
@@ Coverage Diff @@
## refactor #176 +/- ##
============================================
+ Coverage 58.15% 58.20% +0.05%
============================================
Files 56 56
Lines 5690 5685 -5
============================================
Hits 3309 3309
+ Misses 2381 2376 -5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again, some questions that I suspect are not blockers
|
||
time_properties_ds.leap59 = false; | ||
time_properties_ds.leap61 = false; | ||
time_properties_ds.current_utc_offset = 37; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this magic constant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, suggest we refactor this later (this was moved code)
time_properties_ds.leap59 = false; | ||
time_properties_ds.leap61 = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we combine these like we do with the NtpLeapIndicator
? or is it easier to keep them separate? they cannot both be true at the same time (right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, suggest we refactor this later (this was moved code)
2f64.powi(self.config.log_announce_interval as i32) | ||
* (self.config.announce_receipt_timeout as f64), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this calculation comes up a bunch. Can it be a helper function ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, suggest we refactor this later (this was moved code)
No description provided.