Reworked bmca running to use new interface. #176
Conversation
Codecov Report
@@ Coverage Diff @@
## refactor #176 +/- ##
============================================
+ Coverage 58.15% 58.20% +0.05%
============================================
Files 56 56
Lines 5690 5685 -5
============================================
Hits 3309 3309
+ Misses 2381 2376 -5
|
|
|
||
| time_properties_ds.leap59 = false; | ||
| time_properties_ds.leap61 = false; | ||
| time_properties_ds.current_utc_offset = 37; |
There was a problem hiding this comment.
what is this magic constant?
There was a problem hiding this comment.
True, suggest we refactor this later (this was moved code)
| time_properties_ds.leap59 = false; | ||
| time_properties_ds.leap61 = false; |
There was a problem hiding this comment.
can we combine these like we do with the NtpLeapIndicator? or is it easier to keep them separate? they cannot both be true at the same time (right?)
There was a problem hiding this comment.
True, suggest we refactor this later (this was moved code)
| 2f64.powi(self.config.log_announce_interval as i32) | ||
| * (self.config.announce_receipt_timeout as f64), |
There was a problem hiding this comment.
this calculation comes up a bunch. Can it be a helper function ?
There was a problem hiding this comment.
True, suggest we refactor this later (this was moved code)
No description provided.