Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved all message handling into the new interface. #174

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

davidv1992
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

❗ No coverage uploaded for pull request base (refactor@2869d30). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             refactor     #174   +/-   ##
===========================================
  Coverage            ?   58.49%           
===========================================
  Files               ?       56           
  Lines               ?     5657           
  Branches            ?        0           
===========================================
  Hits                ?     3309           
  Misses              ?     2348           
  Partials            ?        0           

}

#[tokio::test]
async fn test_measurement_flow() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is duplicate with the tests in state/slave.rs

Base automatically changed from sync-delay-mechanism to refactor July 12, 2023 09:45
Copy link
Contributor

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left 2 questions. I suspect they are not blockers

statime/src/port/mod.rs Show resolved Hide resolved
statime/src/port/state/slave.rs Show resolved Hide resolved
@bramtweedegolf bramtweedegolf merged commit ec7151b into refactor Jul 13, 2023
4 checks passed
@bramtweedegolf bramtweedegolf deleted the handle_message_replacement branch July 13, 2023 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants