Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TestableERC20Wrapper #34

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

gianfra-t
Copy link
Contributor

Added TestableERC20Wrapper contract in order to replace MockERC20 in tests.

Mint/Burn functions are added that will only be called in tests, and that call corresponding chain extensions for minting/burning specified token.

Refer to Issue #26 from wasm-deploy

@ebma
Copy link
Member

ebma commented Oct 4, 2023

Is this ready for review? If so, please add some techies as reviewers.

@gianfra-t
Copy link
Contributor Author

This is not so much of a very big change but the addition of the ERC20 wrapper with just two methods for testing.

Base automatically changed from 32-support-latest-solang-version to master October 4, 2023 13:30
Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. But the changes to the foucoco-standalone chain-extension that are part of pendulum-chain/wasm-deploy#26 don't exist yet, do they?
Maybe we should first modify that chain-extension before we merge this one, so that we are 100% sure that the required input arguments are what we define here.

@gianfra-t
Copy link
Contributor Author

Indeed, I have added them to the standalone chain but I couldn't push changes I realize since I don't have access. @ebma if you can could you please give me write access to that repo? I will link those changes here.

@ebma
Copy link
Member

ebma commented Oct 4, 2023

Can you try pushing again @gianfra-t? I changed the settings for collaborators.

@gianfra-t
Copy link
Contributor Author

Thanks! The changes to the chain can be found here.

As part of this changes I have tested and they work as expected.

Perhaps in the future when implementing on foucoco or amplitude, the chain extension definition should be moved to a different file for clarity.

Copy link
Member

@ebma ebma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for linking to the changes on the foucoco-standalone chain, will you create a PR for those as well?

Can confirm that the code of the smart contract looks good now, so it's ready for merge.

@gianfra-t gianfra-t merged commit 07d548a into master Oct 4, 2023
@gianfra-t gianfra-t deleted the add-mint-burn-extrinsic-calls branch October 4, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants