-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TestableERC20Wrapper #34
Conversation
Is this ready for review? If so, please add some techies as reviewers. |
This is not so much of a very big change but the addition of the ERC20 wrapper with just two methods for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. But the changes to the foucoco-standalone chain-extension that are part of pendulum-chain/wasm-deploy#26 don't exist yet, do they?
Maybe we should first modify that chain-extension before we merge this one, so that we are 100% sure that the required input arguments are what we define here.
Indeed, I have added them to the standalone chain but I couldn't push changes I realize since I don't have access. @ebma if you can could you please give me write access to that repo? I will link those changes here. |
Can you try pushing again @gianfra-t? I changed the settings for collaborators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for linking to the changes on the foucoco-standalone chain, will you create a PR for those as well?
Can confirm that the code of the smart contract looks good now, so it's ready for merge.
Added
TestableERC20Wrapper
contract in order to replace MockERC20 in tests.Mint/Burn functions are added that will only be called in tests, and that call corresponding chain extensions for minting/burning specified token.
Refer to Issue #26 from wasm-deploy