Lee #13
Lee #13
Conversation
There was a problem hiding this comment.
Besides a couple of mainly nit comments, I found interesting the use of a DataStore. I think there will be a good debate where the some logic should belong. I put it in the model, for example, given my past experiences - with Java too - so I think we should agree how to deal with this kind of situation
|
|
||
| books = repo.GetBooks(ctx, filters) | ||
|
|
||
| sort.Slice(books, func(i, j int) bool { return books[i].Id < books[j].Id }) |
There was a problem hiding this comment.
what about this https://pkg.go.dev/cloud.google.com/go/datastore#Query.Order ? 😄
There was a problem hiding this comment.
Found that later, meant to change and forgot
| return | ||
| } | ||
|
|
||
| jsonStr, err := json.MarshalIndent(book, "", " ") | ||
| if err != nil { | ||
| utils.ErrorResponse(w, err) |
|
|
||
| server.Init(host, port) | ||
| server.Init(host, port, client, ctx) |
| return createBooks(it) | ||
| } | ||
|
|
||
| func (brds *BookRepositoryDataStore) Lending(ctx context.Context, id int, borrow bool) (err error) { |
There was a problem hiding this comment.
nit: I understood what the endpoint does, but I found the name a bit confusing what about loan?
There was a problem hiding this comment.
Yeh I struggled with the name
| func buildQuery(filters map[string]string) *datastore.Query { | ||
| query := datastore.NewQuery("Book") | ||
| for filter, value := range filters { | ||
| if strings.EqualFold("title", filter) { |
There was a problem hiding this comment.
how would you modify the method to filter by author and title ? @tomw-1 this is your question 😄
No description provided.