Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Java 22 #282

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Java 22 #282

wants to merge 3 commits into from
+39 −0

Conversation

Stigstille
Copy link

Description

Add a Java 22 yolk

All Submissions:

  • Have you ensured there aren't other open Pull Requests for the same update or change?
  • Have you created a new branch for your changes and PR from that branch and not from your master branch?

gOOvER
gOOvER suggested changes Jan 15, 2025
View reviewed changes
Copy link

@gOOvER gOOvER left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed to add the image to the readme

@Stigstille
Copy link
Author

@gOOvER should be there now

@gOOvER
Copy link

gOOvER commented Jan 15, 2025

@gOOvER should be there now

I can only make suggestions, but it looks great now.
We'll have to wait for parker or quinten. One of the two can do it merge.

But: LGTM

QuintenQVD0
QuintenQVD0 requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to add it to the workflow.

@Stigstille
Copy link
Author

You forgot to add it to the workflow.

Should be fixed now?
I knew I missed something

QuintenQVD0
QuintenQVD0 approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@QuintenQVD0 QuintenQVD0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Stigstille Stigstille requested a review from gOOvER February 4, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuintenQVD0 QuintenQVD0 QuintenQVD0 approved these changes

@gOOvER gOOvER Awaiting requested review from gOOvER

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Stigstille @gOOvER @QuintenQVD0