update shard module to use ST_Subdivide #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big refactor of the
shardmodule to use the new ST_Subdivide() functionality only available in [email protected]This is a cutting-edge feature which requires building from source in order to get all the latest features in
[email protected]The major advantages are a 4x speed improvement on build times and increased stability when generating shards for PIP.
More information is available in the documentation:
https://www.gaia-gis.it/fossil/libspatialite/wiki?name=About+ST_Subdivide%28%29
I've removed my home-grown splitting code which splits polygons alternately horizontally/vertically, I don't foresee any reason we would need to bring that code back but it's in the history if we ever need to support older versions of spatialite.
related: #7 #6