Add support to lang in ngrams_last_token_only_multi

[Joxit]

👋 I did some awesome work for the Pelias project and would love for everyone to have a look at it and provide feedback.

---

Here's the reason for this change 🚀

@bboure found an issue in autocomplete multi-lang field, Edo Tokyo Museum is not returned see #1296 (comment)

---

Here's what actually got changed 👏

Since #1300 we are using two field for autocomplete search, name.default and name.{lang}. name.{lang} was missing in the ngrams_last_token_only_multi query

---

Here's how others can test the changes 👀

Edo Tokyo Museum should now work

[bboure]

Awesome! Thank you @Joxit

[missinglink]

Looks good to me.

It would be nice to have some tests for this in https://github.com/pelias/acceptance-tests to prevent regression.

[orangejulius]

Thanks for fixing this @Joxit!

I was reading along with the comments yesterday and happened to write an acceptance test to examine this issue more closely, so I've opened pelias/acceptance-tests#535 to bring it in. Thanks @bboure for the report and test case as well!

[Joxit]

Yeah, thx @orangejulius for the acceptance test 😄

[missinglink]

Heeeeey @Joxit

I was investigating a bug report today and I noticed something on our dev server which looks incorrect:
https://pelias.github.io/compare/#/v1/autocomplete?lang=de&text=Am+Gro%C3%9Fhausberg%2C+Furtwangen+im+Schwarzwald+deut&debug=1

Dev server is running a newer master branch than the production server.

The screenshot shows it's using phrase.default but name.de, is that possibly due to this PR?
I would expect to see phrase.default and phrase.de.

[Joxit]

Hi @missinglink Yes you're right, I think this is due to this PR 🤔

Maybe I should use admin:add_name_to_multimatch:field instead of admin:add_name_lang_to_multimatch:field...

[missinglink]

It's not super urgent but we should fix it, could you please open an issue/pr so we don't forget?

[missinglink]

Some of those query views are a hot mess, it's becoming increasingly difficult to figure out which does what, where.
I'm probably guilty of the worst of it, we need to clean all that up at some point 🤦

[Joxit]

Ok, I will open an issue and work on it later (I tried something but it will be harder than I expected 😢)
Here is where we update the name.default field to phrase.default:

api/query/view/admin_multi_match_first.js

Lines 32 to 37 in 5d202c4

	vsCopy.var('admin:add_name_to_multimatch:field', 'phrase.default');
	adminFields.forEach(field => {
	if( vsCopy.isset(`admin:${field}:field`) ){
	vsCopy.var(`admin:${field}:field`, vsCopy.var(`admin:${field}:field`).get().replace('.ngram', ''));
	}
	});

😆 I agree 😅