Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[K-SC] 소켓 연결 및 whoAmI 이벤트 등록 성공 #495

Merged
merged 9 commits into from
Jan 17, 2024

Conversation

HiHoi
Copy link
Contributor

@HiHoi HiHoi commented Jan 15, 2024

구현점

  • 소켓 연결
  • whoAmI 이벤트 등록
  • 소켓을 위한 전역 관리 useSocket 구현

1000자 나온건 npm 패키지 때문 입니다.

@HiHoi HiHoi self-assigned this Jan 15, 2024
@HiHoi HiHoi requested a review from a team as a code owner January 15, 2024 11:11
Copy link

sonarcloud bot commented Jan 15, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@SaltySalt77 SaltySalt77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없음을 확인 했습니다! "utf-8-validate"이라는 패키지를 설치하셨던데 utf-8 형식의 문자열에 대한 유효성 검사를 할 수 있게 되는 걸까요?

@HiHoi
Copy link
Contributor Author

HiHoi commented Jan 16, 2024

문제 없음을 확인 했습니다! "utf-8-validate"이라는 패키지를 설치하셨던데 utf-8 형식의 문자열에 대한 유효성 검사를 할 수 있게 되는 걸까요?

이 패키지는 socket.io-client에
의존성이 걸린 패키지입니다. 그래서 설치했을뿐 이 패키지를 직접 사용하진 않았습니다

@HiHoi HiHoi merged commit 0aa512c into peer-42seoul:develop Jan 17, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants