Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[D-TP] DnD 기능 되살리기 #1119

Merged
merged 7 commits into from
Apr 18, 2024
Merged

[D-TP] DnD 기능 되살리기 #1119

merged 7 commits into from
Apr 18, 2024

Conversation

hyeon81
Copy link
Contributor

@hyeon81 hyeon81 commented Apr 5, 2024

image

  • React-grid-layout의 Grid-Layout을 ResponsiveGridLayout 컴포넌트로 변경
  • 레이아웃을 벗어났을 때의 오류 처리
  • 모바일-pc뷰의 레이아웃 조정, 모바일 사이즈일때 수정 버튼 비활성화
  • 기타 등등을... 수정했습니다. 간헐적으로 오류가 나타날 수 있는데 버그 리포트해주시면 감사하겠습니다.

#1101

@hyeon81 hyeon81 self-assigned this Apr 5, 2024
@hyeon81 hyeon81 marked this pull request as ready for review April 5, 2024 07:09
@hyeon81 hyeon81 requested a review from a team as a code owner April 5, 2024 07:09
@hyeon81 hyeon81 requested review from yoouyeon and joonseong11 and removed request for a team April 5, 2024 07:09
@hyeon81 hyeon81 changed the base branch from release-1.0.7 to release-1.0.8 April 5, 2024 12:26
asroq1
asroq1 previously approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@asroq1 asroq1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DND는 참 사이드이펙트가 많이 발생할 수 있는 여지가 있고 어려운 파트인데 고생하셨습니다.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hyeon81 hyeon81 requested a review from asroq1 April 18, 2024 10:30
@hyeon81 hyeon81 merged commit af4f3b7 into release-1.0.8 Apr 18, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 1.0.7/teamPage/1101 branch June 26, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asroq1 asroq1 asroq1 approved these changes

@yoouyeon yoouyeon Awaiting requested review from yoouyeon yoouyeon is a code owner automatically assigned from peer-42seoul/frontend

@joonseong11 joonseong11 Awaiting requested review from joonseong11 joonseong11 is a code owner automatically assigned from peer-42seoul/frontend

Assignees

@hyeon81 hyeon81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyeon81 @asroq1