Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUBLIC] SkillAutocomplete 무한 리렌더링 해결 #1115

Merged
merged 3 commits into from
Apr 18, 2024

Conversation

SaltySalt77
Copy link
Contributor

수정 사항

  1. 스킬 자동 완성에서 무한 리렌더링 현상을 수정하였습니다. timeout이 0이 되면 값을 더 빼지 않는 것으로 처리하였습니다.
    참고 : [PUBLIC] 모집글 re-render issue #1051

@SaltySalt77 SaltySalt77 self-assigned this Mar 26, 2024
@SaltySalt77 SaltySalt77 requested a review from a team as a code owner March 26, 2024 12:25
@SaltySalt77 SaltySalt77 requested review from HiHoi and asroq1 and removed request for a team March 26, 2024 12:25
Copy link

sonarcloud bot commented Mar 26, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@HiHoi HiHoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

전체적으로 보았을 때

  1. 코드를 나누고
  2. AutoComplete에서 타임아웃으로 따로 설정
    이 두 파트로 막은 거 처럼 보입니다. 정말 수고하셨습니다.

@SaltySalt77 SaltySalt77 merged commit 4bd4ff1 into release-1.0.8 Apr 18, 2024
3 checks passed
@yoouyeon yoouyeon deleted the 1051-public-skillAutocomplete branch June 26, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants