Support Elixir 1.18 in GitHub CI #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We also bump Credo to resolve warnings on missing functions.
kianmeng
force-pushed
the
support-elixir-118
branch
from
fcc0266 to
e2a543a
Compare
kianmeng
commented
Jan 16, 2025
| @@ -42,6 +42,7 @@ defmodule Goth.Mixfile do | |||
| {:jose, "~> 1.11"}, | |||
| {:jason, "~> 1.1"}, | |||
| {:finch, "~> 0.17"}, | |||
| {:castore, "~> 1.0", only: :test}, | |||
| {:bypass, "~> 2.1", only: :test}, | |||
There was a problem hiding this comment.
1) test returns {:error, err} when HTTP call fails hard (Goth.ClientTest)
Error: test/goth/client_test.exs:219
** (RuntimeError) default CA trust store not available; please add `:castore` to your project's dependencies or specify the trust store using the :cacertfile/:cacerts option within :transport_options. From OTP 25, you can also use:
* :public_key.cacerts_get/0 to get certificates that you loaded from files or
* from the OS with :public_key.cacerts_load/0,1
See: https://www.erlang.org/blog/my-otp-25-highlights/#ca-certificates-can-be-fetched-from-the-os-standard-place
code: assert {:error, _} = Client.get_access_token("my-scope")
stacktrace:
(mint 1.6.2) lib/mint/core/transport/ssl.ex:7[16](https://github.com/kianmeng/goth/pull/2/checks#step:10:17): Mint.Core.Transport.SSL.raise_on_missing_castore!/0
(mint 1.6.2) lib/mint/core/transport/ssl.ex:579: Mint.Core.Transport.SSL.add_cacerts/1
(mint 1.6.2) lib/mint/core/transport/ssl.ex:446: Mint.Core.Transport.SSL.add_verify_opts/2
(mint 1.6.2) lib/mint/core/transport/ssl.ex:436: Mint.Core.Transport.SSL.ssl_opts/2
(mint 1.6.2) lib/mint/core/transport/ssl.ex:329: Mint.Core.Transport.SSL.connect/4
(mint 1.6.2) lib/mint/http1.ex:140: Mint.HTTP1.connect/4
(finch 0.[19](https://github.com/kianmeng/goth/pull/2/checks#step:10:20).0) lib/finch/http1/conn.ex:52: Finch.HTTP1.Conn.connect/2
(finch 0.19.0) lib/finch/http1/pool.ex:58: anonymous fn/10 in Finch.HTTP1.Pool.request/6
(nimble_pool 1.1.0) lib/nimble_pool.ex:462: NimblePool.checkout!/4
(finch 0.19.0) lib/finch/http1/pool.ex:52: Finch.HTTP1.Pool.request/6
(finch 0.19.0) lib/finch.ex:493: anonymous fn/4 in Finch.request/3
(telemetry 1.3.0) /home/runner/work/goth/goth/deps/telemetry/src/telemetry.erl:324: :telemetry.span/3
(goth 1.4.5) lib/goth/client.ex:75: Goth.Client.get_access_token/3
test/goth/client_test.exs:[22](https://github.com/kianmeng/goth/pull/2/checks#step:10:23)2: (test)
.............................
Finished in 7.6 seconds (0.6s async, 6.9s sync)
68 tests, 1 failure, 2 excluded
Randomized with seed 726640
Error: Process completed with exit code 2.
kianmeng
commented
Jan 16, 2025
| @@ -4,11 +4,11 @@ | |||
| "cowboy": {:hex, :cowboy, "2.12.0", "f276d521a1ff88b2b9b4c54d0e753da6c66dd7be6c9fca3d9418b561828a3731", [:make, :rebar3], [{:cowlib, "2.13.0", [hex: :cowlib, repo: "hexpm", optional: false]}, {:ranch, "1.8.0", [hex: :ranch, repo: "hexpm", optional: false]}], "hexpm", "8a7abe6d183372ceb21caa2709bec928ab2b72e18a3911aa1771639bef82651e"}, | |||
| "cowboy_telemetry": {:hex, :cowboy_telemetry, "0.4.0", "f239f68b588efa7707abce16a84d0d2acf3a0f50571f8bb7f56a15865aae820c", [:rebar3], [{:cowboy, "~> 2.7", [hex: :cowboy, repo: "hexpm", optional: false]}, {:telemetry, "~> 1.0", [hex: :telemetry, repo: "hexpm", optional: false]}], "hexpm", "7d98bac1ee4565d31b62d59f8823dfd8356a169e7fcbb83831b8a5397404c9de"}, | |||
| "cowlib": {:hex, :cowlib, "2.13.0", "db8f7505d8332d98ef50a3ef34b34c1afddec7506e4ee4dd4a3a266285d282ca", [:make, :rebar3], [], "hexpm", "e1e1284dc3fc030a64b1ad0d8382ae7e99da46c3246b815318a4b848873800a4"}, | |||
| "credo": {:hex, :credo, "1.7.10", "6e64fe59be8da5e30a1b96273b247b5cf1cc9e336b5fd66302a64b25749ad44d", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "71fbc9a6b8be21d993deca85bf151df023a3097b01e09a2809d460348561d8cd"}, | |||
| "credo": {:hex, :credo, "1.7.11", "d3e805f7ddf6c9c854fd36f089649d7cf6ba74c42bc3795d587814e3c9847102", [:mix], [{:bunt, "~> 0.2.1 or ~> 1.0", [hex: :bunt, repo: "hexpm", optional: false]}, {:file_system, "~> 0.2 or ~> 1.0", [hex: :file_system, repo: "hexpm", optional: false]}, {:jason, "~> 1.0", [hex: :jason, repo: "hexpm", optional: false]}], "hexpm", "56826b4306843253a66e47ae45e98e7d284ee1f95d53d1612bb483f88a8cf219"}, | |||
There was a problem hiding this comment.
==> credo
Compiling 252 files (.ex)
warning: Credo.CLI.Command.Categories.Output.Default.print_after_info/4 is undefined or priva
te. Did you mean:
* print/2
│
4 │ use Credo.CLI.Output.FormatDelegator,
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ lib/credo/cli/command/categories/categories_output.ex:4: Credo.CLI.Command.Categories.Cate
goriesOutput.print_after_info/4
kianmeng
commented
Jan 16, 2025
Comment on lines
-19
to
+23
| elixir: 1.13.4 | ||
| otp: 24.3 | ||
| elixir: "1.13" | ||
| otp: "24" | ||
| - pair: | ||
| elixir: 1.17.2 | ||
| otp: 27.0 | ||
| elixir: "1.18" | ||
| otp: "27" |
There was a problem hiding this comment.
Specify versions as string, see https://github.com/erlef/setup-beam?tab=readme-ov-file#specify-versions-as-strings-not-numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We also bump Credo to resolve warnings on missing functions.