Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return Assertion ID #2

Closed
wants to merge 1 commit into from
Closed

Return Assertion ID #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/saml2.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,14 @@ get_session_info = (dom, index_required=true) ->

info

get_assertion_id = (dom) ->
assertion = dom.getElementsByTagNameNS(XMLNS.SAML, 'Assertion')
throw new Error("Expected 1 Assertion; found #{assertion.length}") unless assertion.length is 1

assertion_id = get_attribute_value assertion[0], 'ID'

assertion_id

# Takes in an xml @dom of an object containing a SAML Assertion and returns and object containing the attributes
# contained within the Assertion. It will throw an error if the Assertion is missing or does not appear to be valid.
parse_assertion_attributes = (dom) ->
Expand Down Expand Up @@ -495,6 +503,7 @@ parse_authn_response = (saml_response, sp_private_keys, idp_certificates, allow_
session_info = get_session_info validated_assertion, require_session_index
user.name_id = get_name_id validated_assertion
user.session_index = session_info.index
user.assertion_id = get_assertion_id validated_assertion
if session_info.not_on_or_after?
user.session_not_on_or_after = session_info.not_on_or_after

Expand Down Expand Up @@ -752,3 +761,4 @@ if process.env.NODE_ENV is "test"
module.exports.add_namespaces_to_child_assertions = add_namespaces_to_child_assertions
module.exports.set_option_defaults = set_option_defaults
module.exports.extract_certificate_data = extract_certificate_data
module.exports.get_assertion_id = get_assertion_id
14 changes: 14 additions & 0 deletions test/saml2.coffee
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,6 +266,15 @@ describe 'saml2', ->
name_id = saml2.get_name_id dom_from_test_file('good_assertion_explicit_namespaces.xml')
assert.equal name_id, 'tstudent'

describe 'get_assertion_id', ->
it 'gets the correct assertionId', ->
assertion_id = saml2.get_assertion_id dom_from_test_file('good_assertion.xml')
assert.equal assertion_id, '_3'

it 'parses assertions with explicit namespaces', ->
assertion_id = saml2.get_assertion_id dom_from_test_file('good_assertion_explicit_namespaces.xml')
assert.equal assertion_id, '_3'

describe 'get_session_info', ->
it 'gets the correct session index', ->
info = saml2.get_session_info dom_from_test_file('good_assertion.xml')
Expand Down Expand Up @@ -401,6 +410,7 @@ describe 'saml2', ->
user:
name_id: 'tstudent'
session_index: '_3'
assertion_id: '_3'
given_name: 'Test',
email: '[email protected]',
ppid: 'tstudent',
Expand Down Expand Up @@ -449,6 +459,7 @@ describe 'saml2', ->
user:
name_id: 'tstudent',
session_index: '_3'
assertion_id: '_3'
given_name: 'Test'
attributes:
'http://schemas.xmlsoap.org/ws/2005/05/identity/claims/givenname': [ 'Test' ]
Expand Down Expand Up @@ -557,6 +568,7 @@ describe 'saml2', ->
user:
name_id: undefined
session_index: '_4'
assertion_id: '_3'
session_not_on_or_after: '2016-02-11T21:12:09Z'
attributes: {}

Expand Down Expand Up @@ -628,6 +640,7 @@ describe 'saml2', ->
user:
name_id: undefined
session_index: null
assertion_id: '_3'
session_not_on_or_after: '2016-02-11T21:12:09Z'
attributes: {}

Expand Down Expand Up @@ -998,6 +1011,7 @@ describe 'saml2', ->
user:
name_id: 'tstudent'
session_index: '_3'
assertion_id: '_3'
given_name: 'Test',
email: '[email protected]',
ppid: 'tstudent',
Expand Down