-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a Garth OAuth implementation fixes #95 #96
Conversation
I can confirm that the python script is working as expected after running the following commands
When I run
it works but the workflow continues to download far more than just one activity. I am assuming the final observation is a case of RTFM on my part. |
@sgowtham Thanks for testing, and that's not a RTFM on your part! I was a little bit overzealous when I re-designed the activity fetching 😧 |
Thank you :) This could be a separate feature request, if need be. I am wondering if all files associated with an activity (e.g., csv, fit, gpx, kml, tcx, and hrZones) could be downloaded in one call instead of making separate calls for each such file? |
@sgowtham Whether it's technically possible, I'm not sure. But yeah, that should be a separate feature. Feel free to open an issue to start a discussion :) |
Thanks a lot for investigating this and coming up with a solution! This week I have no time to look at the PR in detail, but I hope I'll manage to early next eek |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your great work :-) I have only some minor suggestions
Hey @pe-st , I addressed all comments :) |
i just tried this PR when i enter:
all activities are downloaded. (because of @SimonBaars: |
I think this was a small glitch that I fixed when merging the PR |
@SimonBaars: Thanks a lot for the fix! |
@SimonBaars @martin @pe-st : from my side also a big Thank You. everything is working with windows and linux. BTW: updating of garth with: |
For full context, see the relevant issue thread: #95
TLDR: Garmin shut down the old authentication flow. The new authentication flow has many security measures in place to script the login. Using a recommendation in an issue on a similar repo, we use the Garth library to implement an OAuth flow, which should be more robust than the original method.
Review notes:
Thanks to @geraudloup for investigating this with me, and @app4g for the support!