Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print error instead of exception in fetch_details #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rascasoft
Copy link

This commit converts the raise exception statement inside the
fetch_details function into a print statement, so that when
working on multi entries (and just some fails) the others can be
processed in any case.

This commit converts the raise exception statement inside the
fetch_details function into a print statement, so that when
working on multi entries (and just some fails) the others can be
processed in any case.
@pe-st
Copy link
Owner

pe-st commented Jul 12, 2024

Hello @rascasoft, sorry for the late feedback. Would a command line option to select your desired behaviour also work? I personally prefer a fail-fast approach in this case, if this problem happens I'd assume a temporary issue with Garmin Connect and I'd want to know that my download is incomplete. If it's just mentioned in a log I'd probably miss it, so I personally prefer the exception behaviour

@rascasoft
Copy link
Author

Actually @pe-st it's been a very long time since I did this, and so whatever fits you is OK by me ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants