Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables and shell checks for postscripts #467

Merged

Conversation

blimlim
Copy link
Collaborator

@blimlim blimlim commented Jul 26, 2024

This pull request covers initial work for #463.

Allowing both syncing and NetCDF conversion for ESM simulations will be easier if the NetCDF conversion is run as a payu postscript, rather than as a userscript. This pull request adds in shell requirement checks and environment variable exports to the postscript submission, which are needed for the NetCDF conversion script.

@pep8speaks
Copy link

pep8speaks commented Jul 26, 2024

Hello @blimlim! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-26 01:01:14 UTC

@blimlim blimlim requested a review from jo-basevi July 26, 2024 00:58
Copy link
Collaborator

@jo-basevi jo-basevi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding that in! The changes look good to me

@blimlim blimlim merged commit eab6a8a into payu-org:master Jul 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants