Skip to content

Commit

Permalink
review concern fix
Browse files Browse the repository at this point in the history
  • Loading branch information
alexanderzaiets-paysera authored and pelanis committed Jun 15, 2023
1 parent b6d6bf7 commit e54e69e
Showing 1 changed file with 19 additions and 19 deletions.
38 changes: 19 additions & 19 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1260,7 +1260,7 @@ Example of parent class, with which calling constructor later would fail:
/**
* @var int[] $params
*/
protected array $params;
private array $params;
public function __construct(int $arg1)
{
$this->params = [$arg1];
Expand Down Expand Up @@ -1613,7 +1613,7 @@ Instead of:
<?php
class BadExample
{
protected string $name;
private string $name;
public function setManagerName(string $name): self
{
$this->name = $name;
Expand Down Expand Up @@ -1878,7 +1878,7 @@ class Manager
/**
* @var ProviderInterface[]
*/
protected $providers = [];
private $providers = [];

public function addProvider(ProviderInterface $provider, string $providerKey): self
{
Expand Down Expand Up @@ -2566,8 +2566,8 @@ use Doctrine\ORM\EntityManagerInterface;
class FooProcessor
{
protected EntityManagerInterface $entityManager;
protected RemoteServiceClient $remoteServiceClient;
private EntityManagerInterface $entityManager;
private RemoteServiceClient $remoteServiceClient;
public function __construct(EntityManagerInterface $entityManager, RemoteServiceClient $remoteServiceClient)
{
Expand Down Expand Up @@ -3131,22 +3131,22 @@ declare(strict_types=1);
class MainEntity
{
protected int $id;
protected string $type;
private int $id;
private string $type;
}
class SubEntity
{
protected int $id;
protected MainEntity $mainEntity;
protected string $subValue;
private int $id;
private MainEntity $mainEntity;
private string $subValue;
}
class AnotherSubEntity
{
protected int $id;
protected MainEntity $mainEntity;
protected string $anotherSubValue;
private int $id;
private MainEntity $mainEntity;
private string $anotherSubValue;
}
```

Expand All @@ -3159,10 +3159,10 @@ declare(strict_types=1);
class Entity
{
protected int $id;
protected string $type;
protected string $subValue;
protected string $anotherSubValue;
private int $id;
private string $type;
private string $subValue;
private string $anotherSubValue;
}
```

Expand All @@ -3179,11 +3179,11 @@ class Entity
}
class SubEntity extends Entity
{
protected string $subValue;
private string $subValue;
}
class AnotherSubEntity extends Entity
{
protected string $anotherSubValue;
private string $anotherSubValue;
}
```

Expand Down

0 comments on commit e54e69e

Please sign in to comment.