Merge pull request #7 from ebaranauskas/BASIC-AUTH-FIX

Authorization header fixed for Basic AUTH
paysera · Nov 18, 2020 · 9ebe561 · 9ebe561
2 parents 6801176 + 27b78c9
commit 9ebe561
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## 2.4.1
+### Fixed
+- Basic authentication `Authorization` header must have prefix `Basic `
+
 ## 2.4.0
 ### Added
 - Added ability to pass any configuration without whitelisting to the client

diff --git a/src/Middleware/Authentication/BasicAuthentication.php b/src/Middleware/Authentication/BasicAuthentication.php
@@ -34,10 +34,12 @@ private function buildAuthHeader(array $auth)
             );
         }
 
-        return base64_encode(sprintf(
+        $credentials = base64_encode(sprintf(
             '%s:%s',
             $auth['username'],
             $auth['password']
         ));
+
+        return sprintf('Basic %s', $credentials);
     }
 }
diff --git a/tests/AuthenticationMiddlewareTest.php b/tests/AuthenticationMiddlewareTest.php
@@ -109,7 +109,7 @@ public function testBasicAuthenticationAdded()
         $auth = $request->getHeaderLine('Authorization');
 
         $this->assertSame(RequestMethodInterface::METHOD_GET, $request->getMethod());
-        $this->assertSame(base64_encode(sprintf('%s:%s', $username, $password)), $auth);
+        $this->assertSame('Basic ' . base64_encode(sprintf('%s:%s', $username, $password)), $auth);
     }
 
     /**