APPSERV-59 Adds MicroProfile 2.3 profile #103
Conversation
| @@ -145,7 +164,7 @@ | |||
| <activation> | |||
| <property> | |||
| <name>payara.version</name> | |||
| <value>/^5\.193(\.\d*)?(-SNAPSHOT)?/</value> | |||
| <value>/5\.19[^1].*|5\.201.*/</value> | |||
There was a problem hiding this comment.
Wouldn't this now match against 5.192? Conflict with profile above.
There was a problem hiding this comment.
Also 5.201 uses metrics 2.2 not 2.0.1
There was a problem hiding this comment.
You are right, I did not think about the default and the version interaction. This needs another profile for 5.201
There was a problem hiding this comment.
Turns out we supported metrics 2.2 from 5.194, so the new profile needs to match both 5.194 and 5.201, with 5.193 supporting metrics 2.0
There was a problem hiding this comment.
Thanks for looking that up
|
@Pandrex247 I think now I got the numbers right. |
| <activation> | ||
| <property> | ||
| <name>payara.version</name> | ||
| <value>/5\.194.*|5\.201.*/</value> |
There was a problem hiding this comment.
This should probably retain the possibility of having -SNAPSHOT at the end due to stability stream / enterprise.
There was a problem hiding this comment.
Doesn't the .* allow that?
There was a problem hiding this comment.
I'd have thought so but there seems to be something wrong with the regex (which isn't obvious to me)
mvn help:active-profiles -Dpayara.version=5.201-SNAPSHOT -am -pl MicroProfile-Metrics/tck-runner ---> mp-metrics-2.2
mvn help:active-profiles -Dpayara.version=5.201.1-SNAPSHOT -am -pl MicroProfile-Metrics/tck-runner ---> Error (same as below - no property version found)
There was a problem hiding this comment.
I can only assume this is due to the illegal regex provided in the other profile (missed / in the start). I tested this after that was corrected and it worked. Another issue was that the CDI api version 2.0.2 was incorrect.
| <activation> | ||
| <property> | ||
| <name>payara.version</name> | ||
| <value>5\.20[^1].*/</value> |
There was a problem hiding this comment.
This doesn't match against 5.202-SNAPSHOT either, but gets by due to default property value.
It seems to outright fail though against 5.202.1-SNAPSHOT - weirdly because it seems to have lost the default value:
andrew@OpenSUSE:~/Git/MicroProfile-TCK-Runners> mvn help:active-profiles -Dpayara.version=5.202.1-SNAPSHOT -Ppayara-server-remote -pl MicroProfile-Metrics/tck-runner
[INFO] Scanning for projects...
[ERROR] [ERROR] Some problems were encountered while processing the POMs:
[ERROR] 'dependencies.dependency.version' for org.eclipse.microprofile.rest.client:microprofile-rest-client-tck:jar must be a valid version but is '${microprofile.rest.client.tck.version}'. @ line 105, column 22
@
[ERROR] The build could not read 1 project -> [Help 1]
There was a problem hiding this comment.
I think it is because 5\.20[^1].*/ is missing the / at the beginning.
|
@Pandrex247 Sorry I was bit sloppy with the testing myself. Now I tested all the possible version and it works for me so it should work for you. |
|
I'm still getting failures when I specify 5.201.1-SNAPSHOT or 5.202.1-SNAPSHOT. |
gives me and gives me |
|
Ahhh, it doesn't seem to like it when I run it from the top-level and specify the project - works fine from the actual module directory |
Yes, profiles and version match behave strange when not run that the leave project. I noticed this before. Not sure this is an issue with profiles in general or just with version matching plugin. |
In connection with PR payara/Payara#4582.
That PR should be merged first.