fix(vertical tabs): text-decoration off #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their shouldn't be an underline on the vertical tabs
|
@andrew-ronaldson along with #73 and the removal of the underline, the only hover treatment is the blue color. Not sure if it was also intended to keep the background hover treatment. |
|
Thanks @christianvogt |
nicolethoen
approved these changes
Jan 13, 2025
|
@andrew-ronaldson could you make this same change on this line so the change is reflected in the docs? And if we want to make a change to the color of the background of the nav item on hover, that change will need to be made in two spots as well. |
|
Approved |
|
🎉 This PR is included in version 6.1.0-prerelease.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74
Their shouldn't be an underline on the vertical tabs