feat(Dropdown deprecated): added rule to replace with MenuToggle #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
force-pushed
the
iss683_replaceKebabToggle
branch
from
89f7528 to
0f005ae
Compare
wise-king-sullyman
approved these changes
Jul 18, 2024
Comment on lines
+154
to
+155
| code: `import { KebabToggle } from "@patternfly/react-core/dist/js/deprecated/components/Dropdown/index.js";`, | ||
| output: `import { MenuToggle } from "@patternfly/react-core";\nimport EllipsisVIcon from "@patternfly/react-icons/dist/esm/icons/ellipsis-v-icon";`, |
There was a problem hiding this comment.
🤔 this may or may not really be an issue, but I think we should import the icon from /js if the consumer is importing stuff from /js already.
We may also need to reevaluate if importing from /esm by default is a safe assumption.... but I wouldn't block over that.
There was a problem hiding this comment.
Made #705 as a followup
| ], | ||
| }, | ||
| { | ||
| code: `import { KebabToggle } from "@patternfly/react-core/dist/dynamic/deprecated/components/Dropdown/index.js";`, |
There was a problem hiding this comment.
Probably the same for /dynamic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #683
Also includes some cleanup/helpers added in.