Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification drawer): Fixed tidle-escaped strings in calc #1162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IvicaArsov
Copy link

Wrong tidle-escaped strings cause a parsing exception when using the postcss-calc nodejs module.
Those are now fixed as specified in the readme.

Description

Write a few sentences describing the overall goals of the pull request's commits.

Changes

  • Replaced all calc(~"...") with ~"calc(...)" as specified in the README so that scss files are properly generated.

Link to rawgit and/or image

No visual changes.

PR checklist (if relevant)

  • Cross browser: works in IE9
  • Cross browser: works in IE10
  • Cross browser: works in IE11
  • Cross browser: works in Edge
  • Cross browser: works in Chrome
  • Cross browser: works in Firefox
  • Cross browser: works in Safari
  • Cross browser: works in Opera
  • Responsive: works in extra small, small, medium and large view ports.
  • Preview the PR: An image or a URL for designer to preview this PR is provided.

@IvicaArsov
Copy link
Author

Is the Travis build failing because #1160 is not merged yet ?

Copy link
Member

@jeff-phillips-18 jeff-phillips-18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IvicaArsov

Wrong tidle-escaped strings cause a parsing exception when using the postcss-calc nodejs module.
Those are now fixed as specified in the readme.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants