Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inline edit): remove clear element in internet explorer #1119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcoker
Copy link
Contributor

@mcoker mcoker commented Aug 3, 2018

fix #1076

Description

There are 2 "x" (clear) icons when editing a text input in IE/edge, because IE has a native pseudo element to clear an input.

Changes

Hiding the IE clear element and using the patternfly icon for consistency.

Link to rawgit and/or image

The build is failing for the tertiary navigation test below, which should have nothing to do with the inline edit pattern.

https://travis-ci.org/michael-coker/patternfly/builds/411338357

compare | ERROR { requireSameDimensions: false, size: isDifferent, content: 11.61%, threshold: 7% }: navbar-tertiary-menu-submenu-default-selected backstop_default_navbar-tertiary-menu-submenu-default-selected_0_container_0_large-device.png

PR checklist (if relevant)

  • Cross browser: works in IE9
  • Cross browser: works in IE10
  • Cross browser: works in IE11
  • Cross browser: works in Edge
  • Cross browser: works in Chrome
  • Cross browser: works in Firefox
  • Cross browser: works in Safari
  • Cross browser: works in Opera
  • Responsive: works in extra small, small, medium and large view ports.
  • Preview the PR: An image or a URL for designer to preview this PR is provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline edit snippet page - clear/empty "x" icons
1 participant