-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
increased the extension's speed #113
base: master
Are you sure you want to change the base?
Conversation
@Ahmed-ata112 thanks for this! I'm traveling for a few weeks so I'll get to this when I return. Cheers 🍻 |
I haven't used this extension lately because it takes about 20 seconds to update the folder list in my current project. I've now built the extension from this PR and that brought the loading time down to about 1 second. Thank you @Ahmed-ata112! 🙏🏻 @patbenatar Thank you for the initial development of this extension. You should really take another look at this PR. |
@alextegelid I'd love to get this merged and released, but I haven't worked on this extension in years and don't have my environment setup to build it nor do I have the time to get it setup these days. Would you be able to package it for release so I can just upload it to the VS Code marketplace? Thanks! |
Unfortunately I'm not sure how to do that. I get a couple of warnings during packaging that I'm not sure how to fix. From what I can understand the warnings might well be a clue as to why the extension is slow to begin with. It says something about Cache and gitignoreToGlog will crash at run-time. If it is the case that gitignoreToGlob crashes, that would explain why it takes forever to build the directory list in my project since the node_modules wouldn't be ignored. That being said, I'm still able to get a vsix-file that I can install manually.
|
@patbenatar @alextegelid I have some time I can try to package it up |
Sweet, thanks guys! |
Thank you all for your interest. I nearly forgot this PR, despite using this extension almost daily. I’m also open to contributing if @pgdaniel seeks any assistance. Additionally, I've implemented the feature mentioned in issue #84 on a separate branch. However, it's occasionally buggy, and I lacked the energy to fix it, assuming the extension's repository was inactive. I believe @pgdaniel might find this contribution interesting as well. |
I replaced the old glob with fast-glob as the former caused a very long loading time with large Projects