Ignore symbolic links when loading directories #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirming this changes resolved my issue as well! Would love to get this merged in :) |
|
@matthewmcgarvey Thanks for the fix! Sorry for my delay in getting to this -- I don't have much time to support this plugin these days. I've gone ahead and given you push access to this repo if you're interested in helping maintain it. It'd be great if we could add test coverage for this change. I started down that path but realized I haven't run the development environment for this project in a long time and looks like things have changed wrt how VS Code extensions are tested (https://code.visualstudio.com/api/working-with-extensions/testing-extension#migrating-from-vscode). |
|
@patbenatar Appreciate it! I'll try to figure out the testing thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #74
The only difference between
statSyncandlstatSyncis that the latter handles symbolic links while the former causes an error. Then we can ignore symbolic links.https://nodejs.org/api/fs.html#fslstatpath-options-callback