Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Supported Ruby Versions #99

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

zacheryph
Copy link
Contributor

@zacheryph zacheryph commented Feb 22, 2024

Closes #97

2.7 has been EoL for almost a year. Removing, and adding 3.2. 3.0 Will be EoL in March but decided to leave in place for now.

This also updates all of the development and test dependencies to play nicely with newer versions of Ruby.

All Gemfiles were all updated as versions of Nokogiri and Pry didn't play well with updated Ruby & Bundler packages.

The Rails sha for rails_master was not updated. It breaks everything, primarily due to ActionView::Helpers::TagHelper::TagBuilder::HTML_VOID_ELEMENTS no longer being a thing at all.

@zacheryph zacheryph force-pushed the ruby-version-update branch 3 times, most recently from f738795 to 6a06ee9 Compare February 23, 2024 06:02
README.md Outdated Show resolved Hide resolved
@patbenatar
Copy link
Owner

Thanks for this!

| The Rails sha for rails_master was not updated. It breaks everything, primarily due to ActionView::Helpers::TagHelper::TagBuilder::HTML_VOID_ELEMENTS no longer being a thing at all.

I opened #101 for this

2.7 has been EoL and 3.0 is EoL in March. Update CI and
everything to support current supported versions of Ruby.

This also updates all of the development and test
dependencies to play nicely with newer versions of Ruby.
@patbenatar patbenatar merged commit 8c3c4a6 into patbenatar:master Feb 23, 2024
12 checks passed
@zacheryph zacheryph deleted the ruby-version-update branch February 23, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Ruby Support; Drop 2.8, 3.0; Add 3.2
2 participants