Allow letOrNull to return R?

passsy · Aug 30, 2024 · 0eb077d · 0eb077d
1 parent 690afad
commit 0eb077d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/lib/src/pick_let.dart b/lib/src/pick_let.dart
@@ -59,7 +59,7 @@ extension NullableLet on Pick {
   ///   user = User.fromJson(pick.asMap());
   /// }
   /// ```
-  R? letOrNull<R>(R Function(RequiredPick pick) block) {
+  R? letOrNull<R>(R? Function(RequiredPick pick) block) {
     if (value == null) return null;
     return block(required());
   }

diff --git a/test/src/pick_let_test.dart b/test/src/pick_let_test.dart
@@ -45,6 +45,10 @@ void main() {
         Person(name: 'John Snow'),
       );
       expect(nullPick().letOrNull((pick) => Person.fromPick(pick)), isNull);
+      // allow lambda to return null
+      final String? a = pick('a').letOrNull((pick) => null);
+      expect(a, isNull);
+      expect(pick('a').letOrNull((pick) => null), isNull);
       expect(
         () => pick('a').letOrNull((pick) => Person.fromPick(pick)),
         throwsA(