Adds Parser APIs in Java and allows for parsing multiple statements #1634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RCHowell
requested changes
Oct 30, 2024
partiql-cli/src/main/kotlin/org/partiql/cli/shell/ShellHighlighter.kt
Outdated
Show resolved
Hide resolved
partiql-eval/src/test/kotlin/org/partiql/eval/internal/PartiQLEvaluatorTest.kt
Show resolved
Hide resolved
partiql-parser/src/main/java/org/partiql/parser/PartiQLParserBuilder.java
Show resolved
Hide resolved
partiql-parser/src/main/kotlin/org/partiql/parser/internal/PFile.kt
Outdated
Show resolved
Hide resolved
Adds type information for PR readability
Adds Javadocs to SourceLocations
Removes use of PFile and PFileV1
Moves parser builder as nested class of parser
johnedquinn
force-pushed
the
v1-parser-java
branch
from
65d72cd
to
b94dfc4
Compare
Replaces all internal parse() invocations with parseSingle()
RCHowell
approved these changes
Nov 1, 2024
Comment on lines
23
to
33
| public class PartiQLParserBuilder { | ||
|
|
||
| public fun build(): PartiQLParser { | ||
| return PartiQLParserDefault() | ||
| /** | ||
| * TODO | ||
| * @return TODO | ||
| */ | ||
| @NotNull | ||
| public PartiQLParser build() { | ||
| return new PartiQLParserDefault(); | ||
| } | ||
| } |
There was a problem hiding this comment.
I believe this is part of the follow-up that @alancai98 will be undertaking for removing the older parser.
Comment on lines
49
to
76
| /** | ||
| * TODO | ||
| * @param source TODO | ||
| * @param ctx TODO | ||
| * @return TODO | ||
| * @throws PErrorListenerException TODO | ||
| * @see PartiQLParserV1#parse(String, Context) | ||
| */ | ||
| @NotNull | ||
| default Result parseSingle(@NotNull String source, @NotNull Context ctx) throws PErrorListenerException { | ||
| Result result = parse(source, ctx); | ||
| if (result.statements.size() != 1) { | ||
| SourceLocation location; | ||
| if (result.statements.size() > 1) { | ||
| location = result.locations.get(result.statements.get(1).tag); | ||
| } else { | ||
| location = null; | ||
| } | ||
| Map<String, Object> properties = new HashMap<String, Object>() {{ | ||
| put("EXPECTED_TOKENS", new ArrayList<String>() {{ | ||
| add("EOF"); | ||
| }}); | ||
| }}; | ||
| PError pError = new PError(PError.UNEXPECTED_TOKEN, Severity.ERROR(), PErrorKind.SYNTAX(), location, properties); | ||
| ctx.getErrorListener().report(pError); | ||
| } | ||
| return result; | ||
| } |
There was a problem hiding this comment.
Parse single doesn't make sense actually with the result. That was a bad suggestion on my part (:
Let me know your thoughts, but removing this seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.