-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FunctionManager and Pluggable Functions Implementations #1168
Conversation
Conformance comparison report
Number passing in both: 5372 Number failing in both: 442 Number passing in Base (090cc67) but now fail: 4 Number failing in Base (090cc67) but now pass: 0 Click here to see
|
961ae2a
to
3147a61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here! Seems like Vladimir's GPML PR was stripped with this PR, so you'll need to manually revert those files. Still have a couple files to review, but left some comments in the meantime.
partiql-ast/src/main/kotlin/org/partiql/ast/helpers/ToLegacyAst.kt
Outdated
Show resolved
Hide resolved
partiql-lang/src/main/kotlin/org/partiql/lang/graph/GpmlTranslator.kt
Outdated
Show resolved
Hide resolved
partiql-lang/src/main/kotlin/org/partiql/lang/CompilerPipeline.kt
Outdated
Show resolved
Hide resolved
partiql-lang/src/main/kotlin/org/partiql/lang/CompilerPipeline.kt
Outdated
Show resolved
Hide resolved
partiql-lang/src/main/kotlin/org/partiql/lang/compiler/PartiQLCompilerBuilder.kt
Outdated
Show resolved
Hide resolved
partiql-lang/src/main/kotlin/org/partiql/lang/eval/ExprFunction.kt
Outdated
Show resolved
Hide resolved
partiql-lang/src/test/kotlin/org/partiql/lang/syntax/PartiQLParserMatchTest.kt
Outdated
Show resolved
Hide resolved
5275b24
to
1467673
Compare
1467673
to
6b53f47
Compare
All looks great to me! Great job! Let's wait for another team member to review/approve before merging. |
partiql-lang/src/main/kotlin/org/partiql/lang/eval/EvaluatingCompiler.kt
Outdated
Show resolved
Hide resolved
partiql-lang/src/main/kotlin/org/partiql/lang/eval/ExprFunction.kt
Outdated
Show resolved
Hide resolved
partiql-lang/src/main/kotlin/org/partiql/lang/eval/impl/FunctionManager.kt
Outdated
Show resolved
Hide resolved
...c/test/kotlin/org/partiql/lang/eval/evaluatortestframework/PartiQLCompilerPipelineFactory.kt
Outdated
Show resolved
Hide resolved
partiql-types/src/main/kotlin/org/partiql/types/function/FunctionParameter.kt
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1168 +/- ##
============================================
- Coverage 73.18% 71.97% -1.22%
+ Complexity 2358 2333 -25
============================================
Files 224 228 +4
Lines 17398 17699 +301
Branches 3202 3243 +41
============================================
+ Hits 12733 12738 +5
- Misses 3680 3969 +289
- Partials 985 992 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Relevant Issues
Description
PartiQL CLI to load pluggable functions
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
YES
Any backward-incompatible changes? [YES/NO]
YES
and experimental PartiQLCompilerPipeline. Please use List to represent functions instead.
with a Deprecation Level of ERROR. Please invoke callWithRequired() instead.
Level of ERROR. Please use multiple implementations of ExprFunction and use the LIST ExprValue to
represent variadic parameters instead.
Any new external dependencies? [YES/NO]
NO
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
YES
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.