Add tests for Ion's typed nulls #1164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5376 Number failing in both: 442 Number passing in Base (55c4496) but now fail: 0 Number failing in Base (55c4496) but now pass: 0 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1164 +/- ##
============================================
- Coverage 73.24% 73.16% -0.08%
+ Complexity 2371 2353 -18
============================================
Files 224 224
Lines 17417 17380 -37
Branches 3155 3199 +44
============================================
- Hits 12757 12716 -41
+ Misses 3682 3679 -3
- Partials 978 985 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yliuuuu
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
PartiQL spec issue related to Ion's typed nulls.
Description
Adds some tests demonstrating the Kotlin implementation's current handling of typed nulls. This behavior is consistent across the partiql-lang-kotlin versions.
Other Information
Updated Unreleased Section in CHANGELOG: No -- no update to public API. Just some tests.
Any backward-incompatible changes? No
Any new external dependencies? No
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.