Adds TODO for the static methods to construct listeners and contexts

partiql · Oct 24, 2024 · 7c389a1 · 7c389a1
1 parent 5446fcd
commit 7c389a1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/partiql-spi/src/main/java/org/partiql/spi/Context.java b/partiql-spi/src/main/java/org/partiql/spi/Context.java
@@ -23,6 +23,7 @@ default PErrorListener getErrorListener() {
      * The default utilizes {@link PErrorListener#abortOnError()} for the {@link Context#getErrorListener()}.
      * @return the default implementation of {@link Context}.
      */
+    // TODO: Should this be a static variable?
     static Context standard() {
         return new Context() {};
     }

diff --git a/partiql-spi/src/main/java/org/partiql/spi/errors/PErrorListener.java b/partiql-spi/src/main/java/org/partiql/spi/errors/PErrorListener.java
@@ -21,14 +21,12 @@ public interface PErrorListener {
      * {@link PErrorException}.
      * @return an {@link PErrorListener} that throws an {@link PErrorException} upon encountering an error.
      */
+    // TODO: Should this be a static variable?
     @NotNull
     static PErrorListener abortOnError() {
-        return new PErrorListener() {
-            @Override
-            public void report(@NotNull PError error) throws PErrorException {
-                if (error.severity.code() == Severity.ERROR) {
-                    throw new PErrorException(error);
-                }
+        return error -> {
+            if (error.severity.code() == Severity.ERROR) {
+                throw new PErrorException(error);
             }
         };
     }