refactor: Upgrade to express 5.0.1 #9390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed some methods to match express 5.0 requirements - Changed PagesRouter.spec.js (req.query is now a getter) - Bumped express to v5 Review and testing required ! Closing #9353 Please enter the commit message for your changes. Lines starting
Thanks for opening this pull request! |
mtrezza
reviewed
Oct 30, 2024
| @@ -244,9 +244,8 @@ export class FilesRouter { | |||
| } | |||
| // run afterSaveFile trigger | |||
| await triggers.maybeRunFileTrigger(triggers.Types.afterSave, fileObject, config, req.auth); | |||
| res.status(201); | |||
| res.status(201).json(saveResult); | |||
There was a problem hiding this comment.
Why are you retuning saveResult directly? The code before your change has only been returning a Location key?
| @@ -299,11 +298,9 @@ export class FilesRouter { | |||
| const { filesController } = config; | |||
| const { filename } = req.params; | |||
| const data = await filesController.getMetadata(filename); | |||
| res.status(200); | |||
| res.json(data); | |||
| res.status(200).json(data); | |||
There was a problem hiding this comment.
Are these changes necessary? If not, please revert.
| @@ -31,7 +31,7 @@ | |||
| "commander": "12.1.0", | |||
| "cors": "2.8.5", | |||
| "deepcopy": "2.1.0", | |||
| "express": "4.21.0", | |||
| "express": "^5.0.0", | |||
There was a problem hiding this comment.
Please revert package.json and package-lock.json and then run npm i -E [email protected]
| await verifyEmail(req); | ||
| expect(goToPage.calls.all()[0].args[1]).toBe(pages.emailVerificationLinkInvalid); | ||
| }); | ||
|
|
There was a problem hiding this comment.
Could you please revert these dirty lines
mtrezza
changed the title
mtrezza
reviewed
Oct 30, 2024
| req.query.locale = 'yo-LO'; | ||
|
|
||
| const queryWithLocale = { ...req.query, locale: 'yo-LO' }; | ||
| req = { ...req, query: queryWithLocale }; |
There was a problem hiding this comment.
This looks strange, what are you trying to do there?
Comment on lines
-452
to
+453
| }); | ||
|
@xooolod Before you submit your PR for review, please run the tests locally to see whether they all pass. This makes it easier for you to spot errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Issue
Review and testing required !
Closes: #9353
Approach
Tasks