slot-based-collator: Implement dedicated block import #6481
+384
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `SlotBasedBlockImport` job is to collect the storage proofs of all blocks getting imported. These storage proofs alongside the block are being forwarded to the collation task. Right now they are just being thrown away. More logic will follow later. Basically this will be required to include multiple blocks into one `PoV` which will then be done by the collation task.
Comment on lines
+107
to
+111
| runtime_api.record_proof(); | ||
| let recorder = runtime_api | ||
| .proof_recorder() | ||
| .expect("Proof recording is enabled in the line above; qed."); | ||
| runtime_api.register_extension(ProofSizeExt::new(recorder)); |
There was a problem hiding this comment.
nit: there could be an util function to call record_proof and register recorder extension. Seems that this pattern starts spreading across the codebase.
| handle_collation_message(message, &collator_service, &mut overseer_handle).await; | ||
| }, | ||
| block_import_msg = block_import_handle.next().fuse() => { | ||
| // TODO: Implement me. |
There was a problem hiding this comment.
nit: is there some ticket number to refer here?
| RuntimeApi: Send + ConstructNodeRuntimeApi<Block, ParachainClient<Block, RuntimeApi>>, | ||
| { | ||
| type BlockImport = Arc<ParachainClient<Block, RuntimeApi>>; | ||
| type ExtraReturnValue = (); |
There was a problem hiding this comment.
nit: maybe BlockImportAuxiliaryData would be a better naming?
And also generic type in ParachainService could be BIAuxiliaryData?
| <Self::WrapBlockImport as InitBlockImport<Self::Block, Self::RuntimeApi>>::BlockImport, | ||
| >; | ||
|
|
||
| type WrapBlockImport: InitBlockImport<Self::Block, Self::RuntimeApi>; |
There was a problem hiding this comment.
nit: naming again: maybe WrappedBlockImport?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SlotBasedBlockImportjob is to collect the storage proofs of all blocks getting imported. These storage proofs alongside the block are being forwarded to the collation task. Right now they are just being thrown away. More logic will follow later. Basically this will be required to include multiple blocks into onePoVwhich will then be done by the collation task.