Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for items weight in pallet parameters #6477

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gonzamontiel
Copy link

@gonzamontiel gonzamontiel commented Nov 14, 2024

This PR addresses potential discrepancies in weight measurement by accounting for all parameters at block initialization.

It introduces a mechanism to account for the weight (both ref_time and proof_size) of all parameters at the start of each block. This is necessary to account for parameters that might be accessed in scenarios not covered by benchmarking. An example could be the parameter usage within the OnChargeTransaction of the pallet_transaction_payment.

Checklist

  • My PR includes a detailed description as outlined in the "Description" and its two subsections above.
  • My PR follows the labeling requirements of this project (at minimum one label for T required)
    • External contributors: ask maintainers to put the right label on your PR.
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Nov 14, 2024

User @gonzamontiel, please sign the CLA here.

@gonzamontiel gonzamontiel marked this pull request as ready for review November 14, 2024 09:20
@gonzamontiel gonzamontiel requested a review from a team as a code owner November 14, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants