Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport https://github.com/paritytech/polkadot-sdk/pull/6323 to stable2412 #6473

Open
wants to merge 2 commits into
base: stable2412
Choose a base branch
from
Open

backport https://github.com/paritytech/polkadot-sdk/pull/6323 to stable2412 #6473

wants to merge 2 commits into from

Conversation

gui1117
Copy link
Contributor

@gui1117 gui1117 commented Nov 14, 2024

add transaction source in the transaction extension API.

Transaction extension is introduced in stable2412 so better not to break again later.

@gui1117
[Tx ext stage 2: 1/4] Add TransactionSource as argument in `Transac…
d74a5d8 
…tionExtension::validate` (#6323)

## Meta

This PR is part of 4 PR:
* #6323
* #6324
* #6325
* #6326

## Description

One goal of transaction extension is to get rid or unsigned
transactions.
But unsigned transaction validation has access to the
`TransactionSource`.

The source is used for unsigned transactions that the node trust and
don't want to pay upfront.
Instead of using transaction source we could do: the transaction is
valid if it is signed by the block author, conceptually it should work,
but it doesn't look so easy.

This PR add `TransactionSource` to the validate function for transaction
extensions

(cherry picked from commit 8e3d929)
@gui1117 gui1117 requested a review from a team as a code owner November 14, 2024 02:09
@gui1117 gui1117 added the A3-backport Pull request is already reviewed well in another branch. label Nov 14, 2024
@paritytech-review-bot paritytech-review-bot bot requested a review from a team November 14, 2024 02:10
@github-actions GitHub Actions
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gui1117