Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elastic scaling RFC 103 end-to-end test #6452

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

alindima
Copy link
Contributor

Adds a zombienet test which verifies that elastic scaling works correctly both with the MVP and the new RFC 103 implementation which sends the core selector as a UMP signal.

Also enables the V2 receipts node feature for testnet genesis config.

Part of #5049

@alindima alindima added R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network. T10-tests This PR/Issue is related to tests. labels Nov 12, 2024
@alindima alindima requested a review from a team as a code owner November 12, 2024 12:00
Comment on lines 18 to 19
limits = { memory = "4G", cpu = "3" }
requests = { memory = "4G", cpu = "3" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can CPU be lowered ? Parachain blocks are empty and it's a tiny network.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this from the 0001 test, but I think you're right that it's too much

command = "test-parachain"
args = ["-laura=trace,runtime=info,cumulus-consensus=trace,consensus::common=trace,parachain::collation-generation=trace,parachain::collator-protocol=trace,parachain=debug", "--force-authoring", "--experimental-use-slot-based"]

# Second collator uses UMP commitments (RFC 103).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test makes 0001 obsolete. Why not just replace it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not really, since it uses adder-collator, not a cumulus-based one, which uses the collator_fn instead of SubmitCollation and also does not have the UMP signal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T8-polkadot This PR/Issue is related to/affects the Polkadot network. T10-tests This PR/Issue is related to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants