-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frame-benchmarking: Use correct components for pallet instances #6435
Merged
+155
−34
Commits on Nov 11, 2024
-
frame-benchmarking: Use correct components for pallet instances
When using multiple instances of the same pallet, each instance was executed with the components of all instances. While actually each instance should only be executed with the components generated for the particular instance. The problem here was that in the runtime only the pallet-name was used to determine if a certain pallet should be benchmarked. When using instances, the pallet name is the same for both of these instances. The solution is to also take the instance name into account. The fix requires to change the `Benchmark` runtime api to also take the `instance`. The node side is written in a backwards compatible way to also support runtimes which do not yet support the `instance` parameter.
Configuration menu - View commit details
-
Copy full SHA for eaacf95 - Browse repository at this point
Copy the full SHA eaacf95View commit details -
Configuration menu - View commit details
-
Copy full SHA for 728e21d - Browse repository at this point
Copy the full SHA 728e21dView commit details -
Update substrate/frame/benchmarking/Cargo.toml
Co-authored-by: clangenb <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7ec4851 - Browse repository at this point
Copy the full SHA 7ec4851View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3c82c8d - Browse repository at this point
Copy the full SHA 3c82c8dView commit details -
Co-authored-by: Adrian Catangiu <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ff94277 - Browse repository at this point
Copy the full SHA ff94277View commit details -
Configuration menu - View commit details
-
Copy full SHA for a172feb - Browse repository at this point
Copy the full SHA a172febView commit details -
Configuration menu - View commit details
-
Copy full SHA for 03f762c - Browse repository at this point
Copy the full SHA 03f762cView commit details -
Configuration menu - View commit details
-
Copy full SHA for d29d88e - Browse repository at this point
Copy the full SHA d29d88eView commit details
Commits on Nov 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c09c428 - Browse repository at this point
Copy the full SHA c09c428View commit details
Commits on Nov 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 136711d - Browse repository at this point
Copy the full SHA 136711dView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.