Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frame-benchmarking: Use correct components for pallet instances #6435

Merged
merged 10 commits into from
Nov 13, 2024

Commits on Nov 11, 2024

  1. frame-benchmarking: Use correct components for pallet instances

    When using multiple instances of the same pallet, each instance was executed with the components of
    all instances. While actually each instance should only be executed with the components generated
    for the particular instance. The problem here was that in the runtime only the pallet-name was used to determine
    if a certain pallet should be benchmarked. When using instances, the pallet name is the same for both of these
    instances. The solution is to also take the instance name into account.
    
    The fix requires to change the `Benchmark` runtime api to also take the `instance`. The node side is written in a backwards
    compatible way to also support runtimes which do not yet support the `instance` parameter.
    bkchr committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    eaacf95 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    728e21d View commit details
    Browse the repository at this point in the history
  3. Update substrate/frame/benchmarking/Cargo.toml

    Co-authored-by: clangenb <[email protected]>
    bkchr and clangenb authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    7ec4851 View commit details
    Browse the repository at this point in the history
  4. Cargo.lock

    bkchr committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    3c82c8d View commit details
    Browse the repository at this point in the history
  5. Update prdoc/pr_6435.prdoc

    Co-authored-by: Adrian Catangiu <[email protected]>
    bkchr and acatangiu authored Nov 11, 2024
    Configuration menu
    Copy the full SHA
    ff94277 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a172feb View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    03f762c View commit details
    Browse the repository at this point in the history
  8. Fix compilation

    bkchr committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    d29d88e View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2024

  1. Update prdoc/pr_6435.prdoc

    bkchr authored Nov 12, 2024
    Configuration menu
    Copy the full SHA
    c09c428 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. Make the overlord happy

    bkchr committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    136711d View commit details
    Browse the repository at this point in the history