Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: add ARM macos build binaries job #6427

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

iulianbarbu
Copy link
Contributor

@iulianbarbu iulianbarbu commented Nov 10, 2024

Description

This PR adds the required changes to release polkadot, polkadot-parachain and polkadot-omni-node binaries built on Apple Sillicon macos.

Integration

This addresses requests from the community for such binaries: #802, and they should be part of the Github release page.

Review Notes

Test on paritytech-stg solely focused on macos binaries: https://github.com/paritytech-stg/polkadot-sdk/actions/runs/11824692766/job/32946793308, except the steps related to pgpkms (which need AWS credentials, missing from paritytech-stg). The binary names don't have a darwin-arm identifier, and conflict with the existing x86_64-linux binaries. I haven't tested building everything on paritytech-stg because the x86_64-linux builds run on unbutu-latest-m which isn't enabled on pairtytech-stg (and I haven't asked CI team to enable one), so testing how to go around naming conflicts should be covered next.

TODO

  • Test the workflow start to end (especially the last bits related to uploading the binaries on S3 and ensuring the previous binaries and the new ones coexist harmoniously on S3/action artifacts storage without naming conflicts) @EgorPopelyaev
  • Publish the arm binaries on the Github release page - to clarify what's needed @iulianbarbu . Current practice is to manually publish the binaries built via release-build-rc.yml workflow, taken from S3. Would be great to have the binaries there in the first place before working on automating this, but I would also do it in a follow up PR.

Follow ups

  • unify the binaries building under release-30_publish_release_draft.yml maybe?
  • automate binary artifacts upload to S3 in release-30_publish_release_draft.yml

Signed-off-by: Iulian Barbu <[email protected]>
@iulianbarbu iulianbarbu self-assigned this Nov 10, 2024
@iulianbarbu iulianbarbu added the R0-silent Changes should not be mentioned in any release notes label Nov 10, 2024
@iulianbarbu iulianbarbu marked this pull request as ready for review November 10, 2024 16:01
@iulianbarbu iulianbarbu requested review from a team as code owners November 10, 2024 16:01
@iulianbarbu iulianbarbu marked this pull request as draft November 10, 2024 16:01
@iulianbarbu iulianbarbu changed the title github/workflows: add macos build binaries job github/workflows: add ARM macos build binaries job Nov 14, 2024
@iulianbarbu
Copy link
Contributor Author

@EgorPopelyaev can you take a look at this PR from a testing point of view when you have some time? (the part I tagged you for in the PR description). I can't test the action in terms of binaries S3 upload, and around the naming conflict aspects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant