-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github/workflows: add ARM macos build binaries job #6427
Draft
iulianbarbu
wants to merge
6
commits into
master
Choose a base branch
from
ib-enable-arm-binaries
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+263
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
added
the
R0-silent
Changes should not be mentioned in any release notes
label
Nov 10, 2024
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
had a problem deploying
to
release
November 10, 2024 17:42
— with
GitHub Actions
Failure
iulianbarbu
had a problem deploying
to
release
November 10, 2024 17:42
— with
GitHub Actions
Failure
iulianbarbu
had a problem deploying
to
release
November 10, 2024 17:42
— with
GitHub Actions
Failure
iulianbarbu
had a problem deploying
to
release
November 10, 2024 17:43
— with
GitHub Actions
Failure
iulianbarbu
had a problem deploying
to
release
November 10, 2024 17:43
— with
GitHub Actions
Failure
iulianbarbu
had a problem deploying
to
release
November 10, 2024 17:43
— with
GitHub Actions
Failure
iulianbarbu
had a problem deploying
to
release
November 10, 2024 17:43
— with
GitHub Actions
Failure
Signed-off-by: Iulian Barbu <[email protected]>
Signed-off-by: Iulian Barbu <[email protected]>
iulianbarbu
changed the title
github/workflows: add macos build binaries job
github/workflows: add ARM macos build binaries job
Nov 14, 2024
@EgorPopelyaev can you take a look at this PR from a testing point of view when you have some time? (the part I tagged you for in the PR description). I can't test the action in terms of binaries S3 upload, and around the naming conflict aspects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the required changes to release
polkadot
,polkadot-parachain
andpolkadot-omni-node
binaries built on Apple Sillicon macos.Integration
This addresses requests from the community for such binaries: #802, and they should be part of the Github release page.
Review Notes
Test on paritytech-stg solely focused on macos binaries: https://github.com/paritytech-stg/polkadot-sdk/actions/runs/11824692766/job/32946793308, except the steps related to
pgpkms
(which need AWS credentials, missing from paritytech-stg). The binary names don't have adarwin-arm
identifier, and conflict with the existing x86_64-linux binaries. I haven't tested building everything onparitytech-stg
because the x86_64-linux builds run onunbutu-latest-m
which isn't enabled onpairtytech-stg
(and I haven't asked CI team to enable one), so testing how to go around naming conflicts should be covered next.TODO
release-build-rc.yml
workflow, taken from S3. Would be great to have the binaries there in the first place before working on automating this, but I would also do it in a follow up PR.Follow ups
release-30_publish_release_draft.yml
maybe?release-30_publish_release_draft.yml