-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor pallet society
#6367
Merged
Merged
Refactor pallet society
#6367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 5, 2024
re-gius
added
T2-pallets
This PR/Issue is related to a particular pallet.
T12-benchmarks
This PR/Issue is related to benchmarking and weights.
labels
Nov 5, 2024
re-gius
commented
Nov 5, 2024
@@ -431,7 +435,7 @@ pub struct MemberRecord { | |||
} | |||
|
|||
/// Information concerning a member. | |||
#[derive(Encode, Decode, Clone, PartialEq, Eq, RuntimeDebug, TypeInfo, Default)] | |||
#[derive(Encode, Decode, Clone, PartialEq, Eq, RuntimeDebug, TypeInfo, Default, MaxEncodedLen)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should work because PayoutRecord<Balance, PayoutsVec>
is only used in PayoutRecordFor<T, I>
where PayoutsVec
is a BoundedVec
gui1117
approved these changes
Nov 7, 2024
Co-authored-by: Guillaume Thiolliere <[email protected]>
muharem
reviewed
Nov 12, 2024
muharem
reviewed
Nov 12, 2024
muharem
approved these changes
Nov 12, 2024
Co-authored-by: Muharem <[email protected]>
Co-authored-by: Muharem <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
T2-pallets
This PR/Issue is related to a particular pallet.
T12-benchmarks
This PR/Issue is related to benchmarking and weights.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without_storage_info
and adding bounds on the stored types for palletsociety
- issue [tracking] removewithout_storage_info
for pallets migrating to AH #6289