-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add workflow to test readme generation #6359
Conversation
User @virajbhartiya, please sign the CLA here. |
I have made the changes according to the give code review, please do give it a look and let me know if any other changes are required |
Could you please help me out with the 'check-prdoc' and 'check-labels' CI failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Requested some changes and also please add this jobs to the checks-quick.yml
workflow file before the confirm-required-checks-quick-jobs-passed
job instead of creating a new workflow file.
Co-authored-by: Alexander Samusev <[email protected]>
…nts and update Rust toolchain setup
Co-authored-by: Iulian Barbu <[email protected]>
Co-authored-by: Iulian Barbu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great, thank you @virajbhartiya !
Review required! Latest push from author must always be reviewed |
Can we merge this? |
@alvicsam can you take a look once more? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Nope, my bad, looked better and the bot asked for another review from @paritytech/ci . |
5da4063
Description
Created a workflow to search for README.docify.md in the repo, and run cargo build --features generate-readme in the dir of the file (assuming it is related to a crate). If the git diff shows some output for the README.md, then the file update wasn't pushed on the branch, and the workflow fails.
Closes #6331
Integration
Downstream projects that want to adopt this README checking workflow should:
.github/workflows/readme-check.yml
file to their repositoryREADME.docify.md
files in their project follow the expected formatgenerate-readme
feature flag in their Cargo.toml if not already presentReview Notes
This PR adds a GitHub Actions workflow that automatically verifies README.md files are up-to-date with their corresponding README.docify.md sources. Key implementation details:
README.docify.md
files recursively in the repository--features generate-readme
in that directory