Bridges - revert-back and improve congestion #6231

bkontur · 2024-10-25T08:51:14Z

Closes: #5551
Closes: #5550

Context

Before permissionless lanes, bridges only supported hard-coded, static lanes. The congestion mechanism was based on sending Transact(report_bridge_status(is_congested)) from pallet-xcm-bridge-hub to pallet-xcm-bridge-hub-router. Depending on is_congested, we adjusted the fee factor to increase or decrease fees. This congestion mechanism relied on monitoring XCMP queues, which could cause issues like suspending the entire XCMP queue rather than just the affected bridge.

Additionally, we are progressing with deploying bridge message pallets/routing directly on AssetHub, where we don’t interact with XCMP to perform ExportXcm locally.

Description

This PR re-introduces and improves congestion for bridges:

Enhanced Bridge Congestion Mechanism: The bridge queue mechanism has been restructured to operate independently of XCMP, with a refined protocol for congestion detection and suspension management.
Bridge-Specific Channel Suspension: pallet-xcm-bridge-hub and pallet-xcm-bridge-hub-router now use BridgeId to identify specific bridges, enabling selective suspension and resumption of individual bridge channels.
Dynamic Congestion Detection: pallet-xcm-bridge-hub now includes callbacks for fn suspend_bridge and fn resume_bridge based on congestion status:
- For sibling chains, the router sends xcm::Transact(report_bridge_status(bridge_id, is_congested)) using the stored callback information.
- For local chain deployments, the router manages state directly.
New Stop Threshold: A stop_threshold limit in pallet-xcm-bridge-hub enables or disables ExportXcm::validate, providing a fallback mechanism when the router does not adhere to the suspend signal.
Flexible Message Routing: pallet-xcm-bridge-hub-router has been refactored to support message routing for both sibling chains (ExportMessage) and local deployment (ExportXcm).

These updates improve modularity, allow more granular bridge congestion handling, and support diverse deployment scenarios.

bkontur · 2024-10-25T11:25:35Z

bot fmt
/cmd prdoc --audience runtime_dev --bump patch

bkontur · 2024-10-25T11:51:35Z

/cmd prdoc --audience runtime_dev --bump patch --force

prdoc/pr_6231.prdoc

bkontur · 2024-10-26T20:30:05Z

bot fmt

bkontur · 2024-10-28T15:04:20Z

bot fmt

bkontur · 2024-11-05T12:40:39Z

bot fmt

bkontur · 2024-11-07T13:16:18Z

/cmd fmt

bkontur · 2024-11-07T13:47:59Z

/cmd --help

bkontur · 2024-11-07T15:57:44Z

/cmd bench --runtime asset-hub-westend asset-hub-rococo --pallet pallet_xcm_bridge_hub_router

bkontur · 2024-11-07T16:18:32Z

bot bench cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm_bridge_hub_router
bot bench cumulus-assets --runtime=asset-hub-rococo --pallet=pallet_xcm_bridge_hub_router

bkontur · 2024-11-07T16:45:09Z

/cmd fmt

bkontur · 2024-11-07T16:51:47Z

bot bench -v PIPELINE_SCRIPTS_REF=bko-fix cumulus-assets --runtime=asset-hub-westend --pallet=pallet_xcm_bridge_hub_router
bot bench -v PIPELINE_SCRIPTS_REF=bko-fix cumulus-assets --runtime=asset-hub-rococo --pallet=pallet_xcm_bridge_hub_router

bot bench -v PIPELINE_SCRIPTS_REF=bko-fix cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_messages
bot bench -v PIPELINE_SCRIPTS_REF=bko-fix cumulus-bridge-hubs --runtime=bridge-hub-westend --pallet=pallet_bridge_messages

bkontur · 2024-11-07T21:51:26Z

bot bench -v PIPELINE_SCRIPTS_REF=bko-fix cumulus-bridge-hubs --runtime=bridge-hub-rococo --pallet=pallet_bridge_messages
bot bench -v PIPELINE_SCRIPTS_REF=bko-fix cumulus-bridge-hubs --runtime=bridge-hub-westend --pallet=pallet_bridge_messages
bot bench -v PIPELINE_SCRIPTS_REF=bko-fix cumulus-bridge-hubs --subcommand=xcm --runtime=bridge-hub-rococo --pallet=pallet_xcm_benchmarks::generic
bot bench -v PIPELINE_SCRIPTS_REF=bko-fix cumulus-bridge-hubs --subcommand=xcm --runtime=bridge-hub-westend --pallet=pallet_xcm_benchmarks::generic

bkontur · 2024-11-11T21:43:53Z

/cmd fmt

github-actions · 2024-11-11T21:46:09Z

Command "fmt" has started 🚀 See logs here

github-actions · 2024-11-11T21:46:34Z

Command "fmt" has finished ✅ See logs here

bridges/modules/xcm-bridge-hub-router/src/impls.rs

franciscoaguirre · 2024-11-13T18:04:15Z

bridges/modules/xcm-bridge-hub-router/src/impls.rs

+	/// This function ensures that the `local_origin` matches the expected `Location::here()`. If
+	/// the check passes, it updates the bridge status to congested.


Why does this have to be Location::here()?

This bp_xcm_bridge_hub::LocalXcmChannelManager<BridgeIdOf<T, I>> for Pallet<T, I> implementation only makes sense when the pallet_xcm_bridge_hub_router instance is deployed in the same runtime as pallet_xcm_bridge_hub and/or used with HereOrLocalConsensusXcmChannelManager.

Essentially, this implementation will be used with HereOrLocalConsensusXcmChannelManager when both pallets are deployed on AssetHubs:

pallet_xcm_bridge_hub will serve permissionless lanes for sibling parachains and use ReportBridgeStatusXcmChannelManager (which sends XCM to the sibling) for congestion.

The deployed pallet_xcm_bridge_hub_router on the sibling will be sending ExportMessage.

pallet_xcm_bridge_hub will also serve permissionless lanes created for the AssetHub (Location::here()) and use the router's bp_xcm_bridge_hub::LocalXcmChannelManager<BridgeIdOf<T, I>> for pallet_xcm_bridge_hub_router::Pallet<T, I> implementation for direct congestion management.

The deployed pallet_xcm_bridge_hub_router on the AssetHub will trigger pallet_xcm_bridge_hub ExportXcm with UnpaidLocalExporter.

bridges/modules/xcm-bridge-hub-router/src/impls.rs

bridges/modules/xcm-bridge-hub-router/src/lib.rs

franciscoaguirre · 2024-11-13T19:06:40Z

bridges/modules/xcm-bridge-hub-router/src/lib.rs

+				// if not congested anymore, we can start to decreasing fee factor
+				if !bridge_state.is_congested {
+					let previous_factor = bridge_state.delivery_fee_factor;
+					let new_factor = previous_factor / EXPONENTIAL_FEE_BASE;


Is there some safe division we could use here? I'm a little bit spooked by the loop in on_initialize 😅

We use this division by non-zero const for XCMP, UMP, DMP also.

I have another follow-up TODO for refatoring FeeTracker/PriceForDelivery to reuse here, so I will check better saturating/checked_div there also

bridges/modules/xcm-bridge-hub-router/src/lib.rs

bridges/modules/xcm-bridge-hub/src/benchmarking.rs

Co-authored-by: Francisco Aguirre <[email protected]>

bkontur · 2024-11-14T12:09:08Z

/cmd fmt

github-actions · 2024-11-14T12:11:05Z

Command "fmt" has started 🚀 See logs here

github-actions · 2024-11-14T12:11:30Z

Command "fmt" has finished ✅ See logs here

bkontur added the T15-bridges This PR/Issue is related to bridges. label Oct 25, 2024

bkontur self-assigned this Oct 25, 2024

bkontur force-pushed the bko-bridges-congestion branch 2 times, most recently from 659be89 to b48b8a5 Compare October 25, 2024 21:14

bkontur commented Oct 26, 2024

View reviewed changes

prdoc/pr_6231.prdoc Outdated Show resolved Hide resolved

bkontur force-pushed the bko-bridges-congestion branch from a663bc2 to cbc6ae7 Compare October 26, 2024 20:29

bkontur force-pushed the bko-bridges-congestion branch from c78f9bc to 501a5c0 Compare October 28, 2024 15:01

bkontur force-pushed the bko-bridges-congestion branch 7 times, most recently from c78e707 to 152389a Compare November 5, 2024 12:33

bkontur force-pushed the bko-bridges-congestion branch 2 times, most recently from 900bbec to ca24d6c Compare November 7, 2024 11:40

bkontur force-pushed the bko-bridges-congestion branch from edd9c5c to 38f1bb3 Compare November 7, 2024 13:33

bkontur force-pushed the bko-bridges-congestion branch from f06433a to d329dec Compare November 7, 2024 16:44

command-bot bot deleted a comment from github-actions bot Nov 11, 2024

bkontur added 2 commits November 11, 2024 18:49

Fix

9e11db5

Fix

6513057

Update from bkontur running command 'fmt'

31045aa

bkontur added 2 commits November 11, 2024 22:55

Forgotten prdoc

8a7eb9a

Merge branch 'master' into bko-bridges-congestion

15761c1

bkontur mentioned this pull request Nov 12, 2024

Revisit usage of BridgeTable, NetworkExportTable in the xcm-bridge-router configuration paritytech/parity-bridges-common#2380

Closed

bkontur requested review from serban300, acatangiu and franciscoaguirre November 12, 2024 09:24

franciscoaguirre reviewed Nov 13, 2024

View reviewed changes

bkontur and others added 10 commits November 14, 2024 10:16

Update bridges/modules/xcm-bridge-hub/src/benchmarking.rs

cd92d5e

Co-authored-by: Francisco Aguirre <[email protected]>

Update bridges/modules/xcm-bridge-hub-router/src/lib.rs

4b6deb9

Co-authored-by: Francisco Aguirre <[email protected]>

Update bridges/modules/xcm-bridge-hub-router/src/impls.rs

ac092d3

Co-authored-by: Francisco Aguirre <[email protected]>

Update bridges/modules/xcm-bridge-hub-router/src/impls.rs

393cded

Co-authored-by: Francisco Aguirre <[email protected]>

Merge remote-tracking branch 'origin/master' into bko-bridges-congestion

1bcbbdf

Removed sp_tracing::try_init_simple

bdb8c8a

Update bridges/modules/xcm-bridge-hub-router/src/lib.rs

b8efb0b

Co-authored-by: Francisco Aguirre <[email protected]>

Link types - review comment

162c1f6

PR review - fees -> fee

b8d2742

PR review - change on_initialize to on_idle

ecf3499

Update from bkontur running command 'fmt'

f643ec7

PR review - updated docs

8518de3

bkontur requested a review from franciscoaguirre November 14, 2024 15:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bridges - revert-back and improve congestion #6231

Bridges - revert-back and improve congestion #6231

bkontur commented Oct 25, 2024 •

edited

Loading

bkontur commented Oct 25, 2024

bkontur commented Oct 25, 2024

bkontur commented Oct 26, 2024

bkontur commented Oct 28, 2024

bkontur commented Nov 5, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

franciscoaguirre Nov 13, 2024

bkontur Nov 14, 2024

franciscoaguirre Nov 13, 2024

bkontur Nov 14, 2024

bkontur commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

		/// This function ensures that the `local_origin` matches the expected `Location::here()`. If
		/// the check passes, it updates the bridge status to congested.

Bridges - revert-back and improve congestion #6231

Are you sure you want to change the base?

Bridges - revert-back and improve congestion #6231

Conversation

bkontur commented Oct 25, 2024 • edited Loading

Context

Description

bkontur commented Oct 25, 2024

bkontur commented Oct 25, 2024

bkontur commented Oct 26, 2024

bkontur commented Oct 28, 2024

bkontur commented Nov 5, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 7, 2024

bkontur commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

github-actions bot commented Nov 11, 2024

franciscoaguirre Nov 13, 2024

Choose a reason for hiding this comment

bkontur Nov 14, 2024

Choose a reason for hiding this comment

franciscoaguirre Nov 13, 2024

Choose a reason for hiding this comment

bkontur Nov 14, 2024

Choose a reason for hiding this comment

bkontur commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

github-actions bot commented Nov 14, 2024

bkontur commented Oct 25, 2024 •

edited

Loading