Multi-Asset and Cross-Chain Bounties #6189
Conversation
davidk-pt
added
the
T1-FRAME
|
|
||
| /// An index of a bounty. Just a `u32`. | ||
| pub type BountyIndex = u32; | ||
|
|
||
| type AccountIdLookupOf<T> = <<T as frame_system::Config>::Lookup as StaticLookup>::Source; | ||
|
|
||
| type BountyType<T, I> = Bounty< |
There was a problem hiding this comment.
BountyOf to follow our general naming
| /// The kind of asset this bounty is rewarded in. | ||
| asset_kind: AssetKind, | ||
| /// The (total) amount of the `asset_kind` that should be paid if the bounty is rewarded. | ||
| value: AssetBalance, |
There was a problem hiding this comment.
I would keep this just Balance, since there wont be other balance types. Below for deposit and bond we will have consideration ticket type.
Or if we decide to have a separate PR for migrating to considerations. I would have them as BountyBalance and DepositBalance.
Otherwise might be confusing, because AssetBalance can be native, and NativeBalance can be non-native
| @@ -242,6 +324,9 @@ pub mod pallet { | |||
| #[pallet::constant] | |||
| type DataDepositPerByte: Get<BalanceOf<Self, I>>; | |||
|
|
|||
| #[cfg(feature = "runtime-benchmarks")] | |||
| type BenchmarkDefaultAssetKind: Get<Self::AssetKind>; | |||
There was a problem hiding this comment.
introduce one BenchmarkHelper instead with some specific trait. otherwise we might have too many benchmark specific types. check treasury pallet for reference
| ensure!( | ||
| bounty.value <= max_amount, | ||
| native_amount <= max_amount, |
There was a problem hiding this comment.
this will needs to be wrapped into the context. check the treasury spend call for reference
part of #5500
Introduces the
asset_kindparameter for a bounty and moves the payments processing from theCurrency(only local transfers) trait toPay(simpler alternative allowing cross-chain setups) trait.