-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get rid of libp2p
dependency in sc-authority-discovery
#5842
Conversation
Co-authored-by: Bastian Köcher <[email protected]>
This reverts commit 73860e6.
Good to merge? 👀 |
Let me have a look why zombienet tests are failing. |
@alvicsam can you have a look please? GitHub seems to be stuck in this PR. "Processing updates" is spinning on top of the page since yesterday, and the last commit is not visible in the UI. Merging is also blocked. |
I have no idea tbh, I'm seeing this first time. Not sure what I can do from my side, it looks as some internal github issue. I can only suggest to push an empty commit to re-trigger the update process. |
People in the related community discussion advice to |
It worked! Thanks @alvicsam |
a84f259
Hey @ndkazu, thanks for contributing! Good job here! |
Let's close the issue and think about the next step? 😃 |
Issue
#4859
Description
This PR removes
libp2p
types in authority-discovery, and replace them with network backend agnostic types fromsc-network-types
.The
sc-network
interface is therefore updated accordingly.