Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of libp2p dependency in sc-authority-discovery #5842

Merged
merged 134 commits into from
Nov 13, 2024

Conversation

ndkazu
Copy link
Contributor

@ndkazu ndkazu commented Sep 26, 2024

Issue

#4859

Description

This PR removes libp2p types in authority-discovery, and replace them with network backend agnostic types from sc-network-types.
The sc-network interface is therefore updated accordingly.

@ndkazu
Copy link
Contributor Author

ndkazu commented Nov 12, 2024

Good to merge? 👀

substrate/client/network/src/litep2p/mod.rs Outdated Show resolved Hide resolved
substrate/client/network/src/litep2p/mod.rs Outdated Show resolved Hide resolved
@dmitry-markin
Copy link
Contributor

Good to merge? 👀

Let me have a look why zombienet tests are failing.

@dmitry-markin
Copy link
Contributor

@alvicsam can you have a look please? GitHub seems to be stuck in this PR. "Processing updates" is spinning on top of the page since yesterday, and the last commit is not visible in the UI. Merging is also blocked.

@alvicsam
Copy link
Contributor

I have no idea tbh, I'm seeing this first time. Not sure what I can do from my side, it looks as some internal github issue. I can only suggest to push an empty commit to re-trigger the update process.

@alvicsam
Copy link
Contributor

alvicsam commented Nov 13, 2024

People in the related community discussion advice to turn it off and on again close and reopen the PR.

@dmitry-markin
Copy link
Contributor

I have no idea tbh, I'm seeing this first time. Not sure what I can do from my side, it looks as some internal github issue. I can only suggest to push an empty commit to re-trigger the update process.

It worked! Thanks @alvicsam

@dmitry-markin dmitry-markin added this pull request to the merge queue Nov 13, 2024
@dmitry-markin dmitry-markin removed this pull request from the merge queue due to a manual request Nov 13, 2024
@dmitry-markin dmitry-markin added this pull request to the merge queue Nov 13, 2024
Merged via the queue into paritytech:master with commit a84f259 Nov 13, 2024
191 of 197 checks passed
@dmitry-markin
Copy link
Contributor

Hey @ndkazu, thanks for contributing! Good job here!

@ndkazu
Copy link
Contributor Author

ndkazu commented Nov 13, 2024

Hey @ndkazu, thanks for contributing! Good job here!

Let's close the issue and think about the next step? 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T0-node This PR/Issue is related to the topic “node”.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants